specfile: fedora review changes #88
Conversation
supakeen
force-pushed
the
fedora-review
branch
from
5047b2c to
2fd1aa5
Compare
|
Tests here are broken because |
supakeen
force-pushed
the
fedora-review
branch
from
c6d6643 to
3082cbf
Compare
There was a problem hiding this comment.
For the record, the only concerning thing about this PR is that the Source0 is now hardcoded to bundled releases (as required by the Fedora Packaging Guideline).
We were wondering about how packit handles it in its COPR integration. It seems like it doesn't actually care about the original Source0, and it just overrides it with whatever is needed to build a branch/PR. I verified this by downloading the SRPM, and inspecting the embedded tarball.
Just one thing: @supakeen, can you try removing the version change? In all other projects, we have LATEST_VERSION+1 in the specfile on main, so it would be great to do this here as well (otherwise we would have to adjust the automation I think).
These are leftovers and not currently used in the specfile. Signed-off-by: Simon de Vlieger <[email protected]>
This architecture was retired in Fedora 37. Signed-off-by: Simon de Vlieger <[email protected]>
Signed-off-by: Simon de Vlieger <[email protected]>
Use a Source0 that works directly instead of having to go through automation to build. Signed-off-by: Simon de Vlieger <[email protected]>
Have a proper changelog entry. Signed-off-by: Simon de Vlieger <[email protected]>
supakeen
force-pushed
the
fedora-review
branch
from
a80cafc to
6185fac
Compare
Of course; I've rebased and changed the |
Changes as pointed out in the Fedora package review.