Implement image builder database maintenance (HMS-4244) #1402
+6,848
−96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schuellerf
force-pushed
the
HMS-4244-implement-image-builder-database-maintenance
branch
from
8e097b5
to
12c937d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅ |
schuellerf
force-pushed
the
HMS-4244-implement-image-builder-database-maintenance
branch
from
12c937d
to
0e26d6e
Compare
schuellerf
force-pushed
the
HMS-4244-implement-image-builder-database-maintenance
branch
from
6af80e6
to
dc5cafe
Compare
|
Note: failed |
lzap
previously approved these changes
Nov 15, 2024
|
@lzap |
|
Refactoring this into a separate repo or somehow sharing code with composer was considered but discarded for less effort. |
will be used in more database tests like the image-builder-maintenance
schuellerf
force-pushed
the
HMS-4244-implement-image-builder-database-maintenance
branch
3 times, most recently
from
918f709
to
255d1fd
Compare
image-builder-maintenance for now runs vacuum and cleans all composes older than 2 years (by default) to remove customer related data according to the retention policy As this is not really urgent, it's scheduled once a week on Tuesdays to avoid problems on weekends
the behavior of flushing seems to have changed between postgres 12 and the current (17) so we need a "CHECKPOINT" to assure for vacuum to be tested correctly
for now we'll skip this test as it's not really mission critical and should not stop us from delivering the maintenance job.
instead of implementing our selfs, this should be a more clean and feature rich solution
the test executable was called like the target program
schuellerf
force-pushed
the
HMS-4244-implement-image-builder-database-maintenance
branch
from
255d1fd
to
808d4ec
Compare
also introduces a github action test for the container
schuellerf
force-pushed
the
HMS-4244-implement-image-builder-database-maintenance
branch
from
808d4ec
to
e5de212
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the retention policy requested in https://issues.redhat.com/browse/HMS-4244
image-builder-maintenance for now runs vacuum
and cleans all composes older than 2 years (by default)
to remove customer related data according to the
retention policy
As this is not really urgent, it's scheduled once
a week on Tuesdays to avoid problems on weekends
…should be merged after #1398
Note: this implementation is almost a copy of https://github.com/osbuild/osbuild-composer/tree/main/cmd/osbuild-service-maintenance to stick to the same mechanism