Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add transformation from OSCAL Assessment Plan to OSCAL Assessment Results #48

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

feat: add transformation from OSCAL Assessment Plan to OSCAL Assessment Results #48

wants to merge 7 commits into from
+1,615 −179

Conversation

jpower432
Copy link
Member

@jpower432 jpower432 commented Feb 28, 2025 •
edited
Loading

Description

Add transformation from Assessment Plan to Assessment Results shell.

  • Optionally provide processed Observations (support for C2P) that need to be linked by to the Assessment Plan
  • By default, Create a single observation per Activity step
  • IMPORTANT - models/plans was moved to internal for now while the public API for SDKs is decided in the sdk-conformance repo

Fixes #34
Blocked by #45

How has this been tested?

  • Unit tests added for results generation

Types of changes

  • Hot fix (emergency fix and release)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation (change which affects the documentation site)
  • Breaking change (fix or feature that would cause existing functionality to change)

Quality assurance (all should be covered).

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • All commits are signed-off.

@jpower432
chore: add test data with example SSP
c5df815 
Signed-off-by: Jennifer Power <[email protected]>
@jpower432
feat: add generic implementation of ControlImplementation types
20e8e26 
To reuse existing Implementation parsing logic implemented for Component Definitions,
generic implementation of ControlImplementation, ImplementedRequirement, and
Statements are added.

Signed-off-by: Jennifer Power <[email protected]>
@jpower432
feat: add generic implementation as inputs for Settings creation
95a3027 
Signed-off-by: Jennifer Power <[email protected]>
@jpower432
feat: add top-level transformer for OSCAL SSP to OSCAL AP
6285eeb 
Signed-off-by: Jennifer Power <[email protected]>
@jpower432
fix: updates Assessment Platform to remove empty component array
2b7f2d0 
Assessment Platform is a required field under Assessment Assests
but component are not. This updated that field to ensure there are
no empty component lists.

Signed-off-by: Jennifer Power <[email protected]>
@jpower432
chore: moves models/plans to internal
521b82a 
Plan generation is currently exposed through the
transformers package as part of the public API.

Signed-off-by: Jennifer Power <[email protected]>
@jpower432
feat: adds transformers from OSCAL AP to OSCAL AR
0057253 
Signed-off-by: Jennifer Power <[email protected]>
@jpower432 jpower432 force-pushed the feat/transform-ap-to-ar branch from ec991c1 to 0057253 Compare March 5, 2025 00:15
@jpower432 jpower432 changed the title feat: [WIP] add transformation from OSCAL Assessment Plan to OSCAL Assessment Results feat: add transformation from OSCAL Assessment Plan to OSCAL Assessment Results Mar 5, 2025
@jpower432 jpower432 marked this pull request as ready for review March 5, 2025 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OSCAL Assessment Plan to Assessment Results
1 participant
@jpower432