Merge pull request #51 from leHeix/master

Fix fakeQuat memory leak
oscar-broman · Sep 27, 2021 · 5dfd83d · 5dfd83d
2 parents 1056c0a + 72cf789
commit 5dfd83d
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 6 deletions.
diff --git a/src/Hooks.cpp b/src/Hooks.cpp
@@ -625,9 +625,5 @@ void InstallPreHooks()
 {
 	std::memset(&Player::fakeHealth, 255, sizeof(Player::fakeHealth));
 	std::memset(&Player::fakeArmour, 255, sizeof(Player::fakeArmour));
-
-	for (int i = 0; i < 1000; i++)
-	{
-		Player::fakeQuat[i] = 0;
-	}
+	std::memset(&Player::fakeQuat[0], NULL, sizeof(Player::fakeQuat));
 }
diff --git a/src/Scripting.cpp b/src/Scripting.cpp
@@ -234,9 +234,14 @@ static cell AMX_NATIVE_CALL SetFakeFacingAngle(AMX *amx, cell *params)
 	if(!IsPlayerConnected(playerid))
 		return 0;	
 
+	if (Player::fakeQuat[playerid])
+	{
+		delete Player::fakeQuat[playerid];
+	}
+
 	if ((int)params[2] == 0x7FFFFFFF)
 	{
-		Player::fakeQuat[playerid] = NULL;
+		Player::fakeQuat[playerid] = nullptr;
 	}
 	else
 	{