Support for Cloud Armor preconfigured WAF rules

[brettcurtis]

Summary by CodeRabbit

• New Features

  • Updated to the latest versions of key tools, enhancing functionality and performance.
  • Introduced the Google Beta provider, expanding available resources and features.
  • Added documentation for the new Google Compute Security Policy resource.
  • Updated provider versions in documentation to ensure users have the latest information.

• Bug Fixes

  • Removed deprecated Istio configuration variables to simplify setup.

• Chores

  • Updated configuration files to enhance clarity and maintainability.

[infracost]

💰 Infracost report

This pull request is aligned with your company's FinOps policies and the Well-Architected Framework.

_{This comment will be updated when code changes.}

[coderabbitai]

Walkthrough

The changes encompass updates to version specifications in the .pre-commit-config.yaml and README.md files, as well as the introduction of a new Google Beta provider in Terraform configurations. Several Istio-related input variables have been removed across various files, reflecting a strategic shift towards simplifying the deployment process and enhancing security policies.

Changes

Files	Change Summary
.pre-commit-config.yaml	Versions for pre-commit-terraform and checkov updated from v1.92.1 to v1.94.1 and 3.2.228 to 3.2.239, respectively.
README.md	Google provider version updated from 5.40.0 to 6.0.1; new entry for Google Beta provider added. Documentation enhanced with new resource details for google-beta_google_compute_security_policy.istio_gateway.
regional/README.md	Removal of Istio input variables: istio_config_cluster, istio_control_plane_clusters, istio_external_istiod, istio_remote_injection_path, and istio_remote_injection_url.
regional/manifests/README.md	Kubernetes provider version updated from 2.31.0 to 2.32.0.

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 9206061 and 32ac489.

Files selected for processing (1)

• regional/main.tf (5 hunks)

Files skipped from review as they are similar to previous changes (1)

• regional/main.tf

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 32ac489 and 1c7e697.

Files selected for processing (1)

• regional/main.tf (5 hunks)

Files skipped from review as they are similar to previous changes (1)

• regional/main.tf

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 1c7e697 and e273daf.

Files selected for processing (1)

• regional/main.tf (5 hunks)

Files skipped from review as they are similar to previous changes (1)

• regional/main.tf

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between e273daf and 551fb85.

Files selected for processing (3)

• README.md (2 hunks)
• main.tf (1 hunks)
• regional/main.tf (5 hunks)

Files skipped from review as they are similar to previous changes (3)

• README.md
• main.tf
• regional/main.tf

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 551fb85 and fcb99a7.

Files selected for processing (1)

• regional/main.tf (5 hunks)

Files skipped from review as they are similar to previous changes (1)

• regional/main.tf

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between fcb99a7 and 42a676b.

Files selected for processing (4)

• README.md (2 hunks)
• main.tf (1 hunks)
• regional/README.md (3 hunks)
• regional/main.tf (6 hunks)

Files skipped from review as they are similar to previous changes (3)

• README.md
• regional/README.md
• regional/main.tf

Additional comments not posted (6)

main.tf (6)

32-34: Ensure the use of google-beta provider is necessary.

The google-beta provider is required for the adaptive_protection_config auto_deploy_config block. Ensure that this is the only reason for using the beta provider and that it is necessary for your use case.

Verify if the adaptive_protection_config auto_deploy_config block is available only in the google-beta provider.

---

40-63: Adaptive Protection Configuration: Verify thresholds and settings.

The adaptive protection configuration includes several thresholds and settings. Ensure that these values are appropriate for your use case and that they align with your security requirements.

Double-check the values for confidence_threshold, expiration_sec, impacted_baseline_threshold, and load_threshold to ensure they are suitable for your environment.

---

65-67: Advanced Options Configuration: Log Level.

Setting the log level to "VERBOSE" can generate a large amount of log data. Ensure that your logging infrastructure can handle this volume and that it is necessary for your use case.

Consider if a less verbose log level would be sufficient for your needs.

---

72-97: Rate Limiting Rule: Review settings.

The rate-limiting rule throttles requests from all user IPs. Ensure that the rate_limit_threshold and actions (conform_action and exceed_action) are appropriate for your use case.

Double-check the values for count and interval_sec in the rate_limit_threshold block to ensure they align with your traffic patterns and security requirements.

---

99-112: Default Allow Rule: Priority and Description.

The default allow rule permits all traffic and is set with the highest priority. Ensure that this rule is necessary and that its priority does not conflict with other rules.

Confirm that the priority value 2147483647 is appropriate and that it does not interfere with other security policies.

---

114-130: Dynamic Rules: Verify preconfigured WAF rules.

The dynamic block iterates over local.preconfigured_waf_rules. Ensure that the preconfigured WAF rules are correctly defined and that their parameters (action, description, priority, preview) are appropriate for your use case.

Double-check the definitions of local.preconfigured_waf_rules to ensure they are correctly configured and align with your security requirements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 42a676b and d688eed.

Files selected for processing (4)

• .pre-commit-config.yaml (2 hunks)
• README.md (4 hunks)
• regional/README.md (6 hunks)
• regional/manifests/README.md (3 hunks)

Files skipped from review due to trivial changes (1)

• regional/manifests/README.md

Files skipped from review as they are similar to previous changes (1)

• regional/README.md

Additional comments not posted (4)

.pre-commit-config.yaml (2)

14-14: Version update for pre-commit-terraform is appropriate.

The update from v1.92.1 to v1.94.1 in the pre-commit-terraform repository is a minor version change. It's generally safe to assume that such updates include backward-compatible improvements or bug fixes, which are beneficial. However, it's prudent to verify that this update does not disrupt any existing configurations or workflows.

---

32-32: Version update for checkov is appropriate.

The update from 3.2.228 to 3.2.239 in the checkov repository is also a minor version change. Similar to the pre-commit-terraform update, this is typically indicative of improvements or bug fixes. It is important, however, to ensure that the new version of checkov does not introduce any new issues or incompatibilities with the current project setup.

README.md (2)

76-77: Updated provider versions documented correctly.

The documentation correctly reflects the updated versions for the Google provider (6.0.1) and the Google Beta provider (6.0.1). This is important for users managing their Terraform dependencies, ensuring they are aware of the current versions and any potential changes or improvements these versions might bring.

---

87-87: Addition of new resource type is well-documented.

The addition of the google-beta_google_compute_security_policy.istio_gateway resource in the documentation is a significant update. It broadens the functionality available to users and provides them with more options for securing their deployments. The documentation link provided is correct and will be helpful for users needing detailed information about this new resource.