Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Simplify and fix one-hot encoding #1

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kristofgazso
Copy link

@kristofgazso kristofgazso commented May 4, 2022

The library currently seems to be working with floats for one-hot encoding, and was also using for for loops for it, which is not very parallelizable

This doesn't seem usual, since categorical data points should normally be represented as ints as opposed to floats, as they can be expected to be used as indices

One test is still failing: test_point_counter_iris, maybe because of some weird float use. The final assert in the test seems shows that something is wrong:

old
poisoned                 120
not_poisoned             120
correctly_defended        54
incorrectly_defended       3
original_points_total    120
training_points_total    183

new
poisoned                 281
not_poisoned             -41
correctly_defended       240
incorrectly_defended       0
original_points_total    120
training_points_total    181

would be cool if the devs took a look =))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant