[WIP] Simplify and fix one-hot encoding #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The library currently seems to be working with floats for one-hot encoding, and was also using for for loops for it, which is not very parallelizable
This doesn't seem usual, since categorical data points should normally be represented as ints as opposed to floats, as they can be expected to be used as indices
One test is still failing: test_point_counter_iris, maybe because of some weird float use. The final assert in the test seems shows that something is wrong:
would be cool if the devs took a look =))