chore: add release-drafter gh action #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hy3n4
reviewed
Oct 11, 2024
CONTRIBUTING.md
Outdated
There was a problem hiding this comment.
Do we need to include this file?
There was a problem hiding this comment.
I would rather not included it and just keep the simple rules that currently live in the README
https://github.com/oskoperator/osko?tab=readme-ov-file#contributing
|
Thank you for the PR! That's awesome. I've included some comments. |
jmsantorum
force-pushed
the
main
branch
2 times, most recently
from
3970c7b to
50bf01b
Compare
Signed-off-by: Jose Santorum <[email protected]>
I reviewed it! After simplifying a bit more the config I think now it is ready |
|
Thanks! Let's see what it will create in the main branch :D |
fourstepper
approved these changes
Oct 14, 2024
|
@jmsantorum looks really good the drafter, thanks for the contribution, we appreciate it! :) |
Hy3n4
pushed a commit
that referenced
this pull request
Nov 30, 2024
Signed-off-by: Jose Santorum <[email protected]>
fourstepper
added a commit
that referenced
this pull request
Dec 27, 2024
* feat(alerting): magic alerting hocus pocus Signed-off-by: Hy3n4 <[email protected]> * feat(alert-severities): config like this? Signed-off-by: Robin Opletal <[email protected]> * fix(alert-severities): remove NoSlo severity Signed-off-by: Robin Opletal <[email protected]> * stylistic fixes Signed-off-by: Robin Opletal <[email protected]> * fix(config): nicer Cfg initialization Signed-off-by: Robin Opletal <[email protected]> * stop hardcoding 1-target in alertmanagerrule Signed-off-by: Robin Opletal <[email protected]> * feat(make): make wait for services better when deploying dev infratructure Signed-off-by: Hy3n4 <[email protected]> * feat(alerting): alertmanager config loader edits (#130) * feat(alerting): alertmanager config loader Signed-off-by: Robin Opletal <[email protected]> * generated stuff... Signed-off-by: Robin Opletal <[email protected]> --------- Signed-off-by: Robin Opletal <[email protected]> * chore: add release-drafter gh action (#133) Signed-off-by: Jose Santorum <[email protected]> * feat(magic): some features some fixes mainly fixed duration issues also, added some feature to devel, osko dashboards, kustomize for asier deployment and other cool stuff modified function responsible for creating the alerting rule when magiAlerting is enabled, also added some basic mapping for opsgenie, pagerduty and custom alerting tool. Currently not working as expected tho Signed-off-by: Hy3n4 <[email protected]> * fix(rules): duplicated rules for 5m window Signed-off-by: Hy3n4 <[email protected]> * prometheus helper: simplify unique windows, resolve finalizer API warnings Signed-off-by: Robin Opletal <[email protected]> * at least move uniqueStrings to function Signed-off-by: Robin Opletal <[email protected]> --------- Signed-off-by: Hy3n4 <[email protected]> Signed-off-by: Robin Opletal <[email protected]> Signed-off-by: Jose Santorum <[email protected]> Co-authored-by: Hy3n4 <[email protected]> Co-authored-by: Jose Santorum <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To improve the way releases are done, I want to start with the release content and fill it with the content of the PRs made since the last release.
For that, I'll use https://github.com/marketplace/actions/release-drafter action, and on the next PRs I'll try to fill a CONTRIBUTING.md document and at the same time I'll think about #131 in order to not only fill the release document, but also make a proper release (update project versions, and so on)
Related to #125