Skip to content

Commit

Permalink
Merge pull request #30 from oslabs-beta/npmCDFix
Browse files Browse the repository at this point in the history
Added environment variable syntax to CD
  • Loading branch information
YouruiR authored Jul 13, 2023
2 parents de9bbd6 + 0bc0b29 commit ad47eff
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 8 deletions.
8 changes: 4 additions & 4 deletions .github/workflows/npmCD.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,9 @@ jobs:
id: check_merge
run: |
if [[ "$(git log -1 --pretty=%B "${{ github.event.pull_request.merge_commit_sha }}")" == *"Merge pull request"* ]]; then
echo "::set-output name=is_merged::true"
echo "is_merged=true" >> $GITHUB_ENV
else
echo "::set-output name=is_merged::false"
echo "is_merged=false" >> $GITHUB_ENV
fi
- name: Setup node env
Expand All @@ -35,9 +35,9 @@ jobs:
id: changes
run: |
if git diff --name-only ${{ github.event.pull_request.base.sha }} ${{ github.event.pull_request.merge_commit_sha }} -- npm-package/ | grep -q .; then
echo "::set-output name=changes::true"
echo "changes=true" >> $GITHUB_ENV
else
echo "::set-output name=changes::false"
echo "changes=false" >> $GITHUB_ENV
fi
- name: Deploy
env:
Expand Down
5 changes: 1 addition & 4 deletions npm-package/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,4 @@ $ npm run nextinspect
```
3. Go to your Next.js application page.
4. Open the NextInspect devtool by right clicking the page and selecting inspect. In the double right arrow dropdown to the right of the Network tab, you will be able to view your other devtool extensions.
5. Refresh your page to view telemetry metrics.



5. Refresh your page to view telemetry metrics.

0 comments on commit ad47eff

Please sign in to comment.