Merge pull request #62 from oslabs-beta/feature/sfu

edited aws workflow
oslabs-beta · Jan 14, 2024 · 177ca1e · 177ca1e
2 parents 153a675 + 3eda54f
commit 177ca1e
Show file tree

Hide file tree

Showing 5 changed files with 13 additions and 9 deletions.
diff --git a/.github/workflows/npm-publish.yml b/.github/workflows/npm-publish.yml
@@ -13,7 +13,7 @@ jobs:
           - uses: actions/checkout@v4
           - uses: actions/setup-node@v3
             with:
-                node-version: "20"
+                node-version: '20'
           - run: npm ci
           - name: Publish npm package when version is updated
             uses: JS-DevTools/npm-publish@v3

diff --git a/.github/workflows/rtconnect-test.yml b/.github/workflows/rtconnect-test.yml
@@ -27,7 +27,7 @@ jobs:
     - run: npm ci
     - run: npm run build
     - run: npm run lint
-    # - run: npm test
-    - run: npm run unit-test
+    - run: npm test
+    # - run: npm run unit-test
     # env:
     #   CI: true 
diff --git a/.github/workflows/site-s3-cloudfront.yml b/.github/workflows/site-s3-cloudfront.yml
@@ -9,9 +9,9 @@ on:
 env:
     AWS_REGION: 'us-east-1'
     AWS_S3_BUCKET_NAME: 'rtconnect-s3'
-    AWS_CLOUDFRONT_DISTRIBUTION_ID: ''
+    AWS_CLOUDFRONT_DISTRIBUTION_ID: ${{ secrets.CDN_ID }} # context is correct - problem is a github actions glitch - see: https://github.com/github/vscode-github-actions/issues/222
     S3_BUILD_FILE_PATH: './build'
-    ROLE_NAME: ''
+    # ROLE_NAME: ''
 
 jobs:
     deploy-s3:
@@ -43,7 +43,7 @@ jobs:
           uses: aws-actions/configure-aws-credentials@v4
           with:
             # role-to-assume: ${{ env.ROLE_NAME }}
-            aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY_ID }}
+            aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY_ID }} # context is correct - problem is a github actions glitch - see: https://github.com/github/vscode-github-actions/issues/222
             aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
             aws-region: ${{ env.AWS_REGION }}
 

diff --git a/.github/workflows/slack-notify.yml b/.github/workflows/slack-notify.yml
@@ -2,7 +2,7 @@ name: Slack Notification of CI Status
 
 on: 
   push:
-    branches: ["main", "feature/raisa-cicd"]
+    branches: ["main", "feature/**"]
   pull_request:
     branches: ["main"]
 env:
@@ -18,7 +18,7 @@ jobs:
         id: slack
         uses: slackapi/[email protected]
         with:
-          channel-id: 'C067F896WG5'
+          channel-id: ${{ secrets.SLACK_CHANNEL_ID }}
           slack-message: "Github CI Result: ${{ job.status }}\nGithub PR/Commit URL: ${{ github.event.pull_request.html_url || github.event.head_commit.url }}"
 
 # https://github.com/slackapi/slack-github-action
diff --git a/lib/__tests__/unit/server.unit.test.ts b/lib/__tests__/unit/server.unit.test.ts
@@ -58,4 +58,8 @@ describe('Testing the SignalingChannel class', () => {
 //     sc1.webSocketServer.close();
 //     done();
 //   });
-// });
+// });
+
+
+
+