added job failure expression to workflow

oslabs-beta · Nov 28, 2023 · dd39b3e · dd39b3e
1 parent a012d82
commit dd39b3e
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/.github/workflows/slack-notify.yml b/.github/workflows/slack-notify.yml
@@ -12,11 +12,13 @@ jobs:
         runs-on: ubuntu-latest
         steps:            
             - name: Slack Notify on Failure
-              if: ${{ failure() || success() }}
+              if: ${{ success() }}
               id: slack
               uses: slackapi/[email protected]
               with:
+                channel-id: 'cicd'
                 slack-message: "Github CI result: ${{ job.status }}\n${{ github.event.pull_request.html_url || github.event.head_commit.url }}"
               env:
-                SLACK_WEBHOOK: ${{ secrets.SLACK_WEBHOOK }}
-                SLACK_WEBHOOK_TYPE: INCOMING_WEBHOOK
+                SLACK_BOT_TOKEN: ${{ secrets.SLACK_BOT_TOKEN }}
+                # SLACK_WEBHOOK: ${{ secrets.SLACK_WEBHOOK }}
+                # SLACK_WEBHOOK_TYPE: INCOMING_WEBHOOK