Adding hotel and hostel POI icons #1031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think these icons look great! Let's add a test location as well to the samples list in test/. The spot you linked above is fine, as well as this spot in Manhattan. |
ZeLonewolf
approved these changes
Feb 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two icons, one for
hotel,motel, andguest_house, and a bunk-bed style one forhostel. I previously had included dormitory with thehostelicon, but on the Slack we determined that because dormitories are not open or available for use by the public, they should not be included in this PR. I have the figures in the hostel icon sleeping in different directions primarily to avoid users mistaking the icon for two hotels right on top of each other, even though I know that's not how most people sleep 😄This PR makes progress on #692. Open to any feedback or suggestions!
Localhost link
