Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Railway halts should be styled like stations #856

Merged
merged 1 commit into from
Apr 10, 2023

Conversation

claysmalley
Copy link
Member

I overlooked this when reviewing #790, but railway=halt is a type of station, not a type of stop. In the US, the de facto accepted practice is to use railway=halt for stations with flag-stop service. Other countries use different criteria to distinguish railway=halt from railway=station, but regardless, either can have one or many railway=stop (not rendered) associated with them.

Before/after:

Screenshot from 2023-04-10 15-31-44 Screenshot from 2023-04-10 15-30-39

Screenshot from 2023-04-10 15-41-20 Screenshot from 2023-04-10 15-41-49

@claysmalley claysmalley added bug Something isn't working points of interest labels Apr 10, 2023
@claysmalley claysmalley requested a review from Pengor April 10, 2023 19:49
Copy link
Member

@Pengor Pengor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me, unfortunate this tag isn't used consistently in different places, but oh well 🤷‍♂️

@claysmalley claysmalley merged commit f609183 into main Apr 10, 2023
@claysmalley claysmalley deleted the clay-poi-halt-station branch April 10, 2023 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working points of interest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants