Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add museum icon and brown "attraction" POI color #857

Merged
merged 3 commits into from
Apr 12, 2023
Merged

Add museum icon and brown "attraction" POI color #857

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3373332
Museum
wmisener Apr 11, 2023
e6f232c
Merge branch 'main' into wmisener/museum
wmisener Apr 11, 2023
33dccbc
Merge branch 'main' into wmisener/museum
claysmalley Apr 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -376,7 +376,7 @@ For consistency, POI icons use the following color palette:
| Infrastructure | Pantone 294 | <img src="doc-img/pantone_294.svg" height=18 width=50 /> Blue | 0 63 135 | #003f87 |
| Consumer | UTexas Orange | <img src="doc-img/texas_orange.svg" height=18 width=50 /> Orange | 191 87 0 | #bf5700 |
| Outdoor | | TBD (green?) | | |
| Attraction | | TBD (brown?) | | |
| Attraction | Pantone 469 | <img src="doc-img/pantone_469.svg" height=18 width=50 /> Brown | 105 63 35 | #693f23 |
| Airport | Medium Purple C | <img src="doc-img/pantone_medium_purple_c.svg" height=18 width=50 /> Purple | 78 0 142 | #4e008e |
| Transport | Pantone 234 C | <img src="doc-img/pantone_234_c.svg" height=18 width=50 /> Mauve | 162 0 103 | #a20067 |
| Knockout | | <img src="doc-img/background.svg" height=18 width=50 /> Lt Grayish Orange | 249 245 240 | #f9f5f0 |
3 changes: 3 additions & 0 deletions icons/poi_museum.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
9 changes: 9 additions & 0 deletions scripts/taginfo_template.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -463,6 +463,15 @@
"doc_url": "https://openmaptiles.org/schema/#poi",
"icon_url": "https://raw.githubusercontent.com/ZeLonewolf/openstreetmap-americana/main/icons/poi_town_hall.svg"
},
{
"key": "tourism",
"value": "museum",
"object_types": ["node", "area"],
"description": "Museums are marked by an icon representing a Classical columned building.",
"doc_url": "https://openmaptiles.org/schema/#poi",
"icon_url": "https://raw.githubusercontent.com/ZeLonewolf/openstreetmap-americana/main/icons/poi_museum.svg"
},

{
"key": "amenity",
"value": "clinic",
Expand Down
2 changes: 1 addition & 1 deletion src/constants/color.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ export const poi = {
infrastructure: palette.blue,
consumer: palette.texas_orange,
//outdoor:
//attraction:
attraction: palette.brown,
airport: `hsl(${hue.airport}, 100%, 28%)`,
transport: palette.mauve,
};
13 changes: 12 additions & 1 deletion src/layer/poi.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,14 @@ var iconDefs = {
color: Color.poi.infrastructure,
description: "Doctor's office or clinic",
},
museum: {
classes: {
museum: ["museum"],
},
sprite: "poi_museum",
color: Color.poi.attraction,
description: "Museum",
},
parking: {
classes: {
parking: ["parking"],
Expand Down Expand Up @@ -152,6 +160,8 @@ export const poi = {
...getSubclasses(iconDefs.railway_stop),
],
Color.poi.transport,
["museum"],
Color.poi.attraction,
["hospital", "parking", "school", "townhall"],
Color.poi.infrastructure,
Color.poi.infrastructure,
Expand All @@ -170,9 +180,10 @@ export const poi = {
[
"bus_stop",
"hospital",
"tram_stop",
"museum",
...getSubclasses(iconDefs.school),
"townhall",
"tram_stop",
],
15,
[...getSubclasses(iconDefs.bar), ...getSubclasses(iconDefs.coffee)],
Expand Down