-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Distinct college/university icon #870
Conversation
Adds mortarboard icon, POI.js entries, and taginfo update
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, I think this looks great! I'd at least fix the paths in taginfo_template.json
and the stroke color in the SVG file, but otherwise could be merged 👍
Typo in taginfo path Co-authored-by: Drew M Johnson <[email protected]>
Co-authored-by: Drew M Johnson <[email protected]>
I think the original filename of |
PR Preview: Sprite Sheets: |
Sorry for the slowness on getting back to this. After the discussions on here and slack I don't think there's anything holding this design up from being merged |
Looks great, thanks! |
Fixes #694. Changes the rendering for
. Previously, these were rendered as a generic school icon
; this schoolhouse icon is now reserved for
amenity=college
andamenity=university
(in OMT,class=college
+subclass=college
/university
) to a mortarboard cap-style icon:amenity=school
andamenity=kindergarten
.I think the "higher ed"/"schools for adults" vs "schools for children" is a useful distinction for the map to make. Meanwhile, the distinction between an OSM
college
anduniversity
is a bit fuzzy in practice IMO, so this PR renders both tags the same. In #694, while there were multiple potential icons in various US map samples, the consensus was that a mortarboard cap was the most recognizable symbol of institutions of higher education. The new legend entry is "College or university", whereas the schoolhouse icon retains "School". I think this is not too confusing, but I'm open to suggestions.The icon itself is a modified version of the maki symbol. I'm open to modifying the dimensions/length ratios/style/etc.
I've added rendering to begin at z14, one zoom level out compared to most other POIs, since colleges and universities can be quite important local destinations (I think that eventually starting zoom levels for POIs might need to be reconsidered more holistically, but that's out of scope for this PR). Rendering at z<14 is not currently possible, as non-transport POIs only appear in the tiles at z14 (openmaptiles/openmaptiles#387). In the future, it might also be good to render these objects as areas as well, but I also leave that out for now.
Samples:
![Screen Shot 2023-06-10 at 9 37 51 AM](https://private-user-images.githubusercontent.com/58491489/244882533-77b0ec09-b277-48ee-b5ca-1aa59c79a2fe.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk0NjE1MzQsIm5iZiI6MTczOTQ2MTIzNCwicGF0aCI6Ii81ODQ5MTQ4OS8yNDQ4ODI1MzMtNzdiMGVjMDktYjI3Ny00OGVlLWI1Y2EtMWFhNTljNzlhMmZlLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTMlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEzVDE1NDAzNFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTI5NmY4YWVhOTdlNmRmOTMzYzdhZmIyOWJlZDkzYzk0NTQyYmZmYzk4NDM1MzY1OTExMjYwZDQ4YTYyMGY2YjQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.ruuqgopKrAo_yBRdJFxhyt6pZkflrj8ynHIOdIejlHE)
UCLA z14 (localhost link):
Note that the Anderson School of Management is tagged as
amenity=university
, which may or may not be a tagging error.UCLA z15 (localhost link):
![Screen Shot 2023-06-10 at 9 39 36 AM](https://private-user-images.githubusercontent.com/58491489/244882882-41e27ab2-7b8e-4e3c-8047-e3fbc2cc0784.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk0NjE1MzQsIm5iZiI6MTczOTQ2MTIzNCwicGF0aCI6Ii81ODQ5MTQ4OS8yNDQ4ODI4ODItNDFlMjdhYjItN2I4ZS00ZTNjLTgwNDctZTNmYmMyY2MwNzg0LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTMlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEzVDE1NDAzNFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTNjM2E0OWU3NTY2NzIxNzU3ZDU5ZTI2ZTM5NzQ1ZjljOWQxMmJlOTc5MWZmMjEwYjUyYjMzYWU1Y2YxYTNjZGUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.pP1LT0WAYwWZPxcDTPbnpXmV5PopzJIt_ujAoRiJcmE)
Indiana University Bloomington (localhost link):
![Screen Shot 2023-06-10 at 9 44 16 AM](https://private-user-images.githubusercontent.com/58491489/244883110-477f0d72-6e08-4c27-93a9-f43ee0ec0aa8.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk0NjE1MzQsIm5iZiI6MTczOTQ2MTIzNCwicGF0aCI6Ii81ODQ5MTQ4OS8yNDQ4ODMxMTAtNDc3ZjBkNzItNmUwOC00YzI3LTkzYTktZjQzZWUwZWMwYWE4LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTMlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEzVDE1NDAzNFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTc0NTE5MGE3ZjdhOTQ5OWZjMDM1MmIwZmVlOTBkZDRlMjEwZDk4YWI4MjIzMDVlZTBhNTU2ZDdkN2QwM2ZmN2YmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.4HEw320nsKQ5X2pRX2m6TRdvODkEJXTXophhVtU-YKA)
The icon renders near the center of the university polygon. This may or may not be equivalent to the main activity center of the campus. This problem could be helped, though not really entirely solved, by rendering the area as a boundary.
City College of San Francisco (localhost link):
![Screen Shot 2023-06-10 at 9 58 59 AM](https://private-user-images.githubusercontent.com/58491489/244883761-44e071f8-c5d6-4f2c-b021-924b511e1496.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk0NjE1MzQsIm5iZiI6MTczOTQ2MTIzNCwicGF0aCI6Ii81ODQ5MTQ4OS8yNDQ4ODM3NjEtNDRlMDcxZjgtYzVkNi00ZjJjLWIwMjEtOTI0YjUxMWUxNDk2LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTMlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEzVDE1NDAzNFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWE0YTA2Mzg2ZmM3N2I0NTdjNjRhZTcxYWIyOTRhZjhkMDRhMjdmYzRjNGIzYmYwYjg5MWFiMWVkYmYzOTQ1NDQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.EO3gVPDJtYY06ET776FzpuSQvct8fLvQCutqqreGU3M)
This is a two-year community college, the predominant use of
amenity=college
I anecdotally observe in the US. I see these institutions are more close to a university than they are to e.g. a high school, so I think it makes more sense to render them together with universities.Boston/Cambridge, MA (localhost link):
![Screen Shot 2023-06-10 at 9 53 38 AM](https://private-user-images.githubusercontent.com/58491489/244883581-5af4ace9-ab09-4218-9778-62bc1b3fe710.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk0NjE1MzQsIm5iZiI6MTczOTQ2MTIzNCwicGF0aCI6Ii81ODQ5MTQ4OS8yNDQ4ODM1ODEtNWFmNGFjZTktYWIwOS00MjE4LTk3NzgtNjJiYzFiM2ZlNzEwLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTMlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEzVDE1NDAzNFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTkxNDFkY2NkODM5OTY5MDcwOTUxYjZmZTBlZDc5ZGViNzQ1YTEzMTc2MmI0OWJkNmMwNDk5NGM2OGRiN2Y4NmImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.DfIOkYBMFuVk-JoshFFQ8AtBIxq87monF49sGopxyCw)
Cambridge, UK (localhost link):
![Screen Shot 2023-06-10 at 9 54 48 AM](https://private-user-images.githubusercontent.com/58491489/244883596-0b498e91-bb57-4677-93b2-7345cd2b1233.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk0NjE1MzQsIm5iZiI6MTczOTQ2MTIzNCwicGF0aCI6Ii81ODQ5MTQ4OS8yNDQ4ODM1OTYtMGI0OThlOTEtYmI1Ny00Njc3LTkzYjItNzM0NWNkMmIxMjMzLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTMlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEzVDE1NDAzNFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTc3OWM4ODQ5NmNhODQ0YmU2ZjM0MDZjMTNiMjE1YTgyNmNkZGZmMWQ1ZjEyZmU4ZDA0ZWRmODVhNDcyOGNhYjgmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.kbbp-rBVUU3BKRwEPGh-4aJ208CfRwsrbAi27RFiKRA)
Again, these seem like tagging errors to me, though the UK university/college system is incredibly convoluted so I wouldn't go in and change the tags myself. But this seems at least an improvement over rendering them the same as elementary schools.