Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add USPS Standard Suffix Abbreviation #3414

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

mhsr21
Copy link

@mhsr21 mhsr21 commented May 7, 2024

Added USPS's Standard Suffix Abbreviation for postal addressing (https://pe.usps.com/text/pub28/28apc_002.htm)

@mtmail
Copy link
Collaborator

mtmail commented May 7, 2024

Some entries have the same source and destination text, e.g.

  • Wall -> Wall
  • Ways -> Ways
  • Pike -> Pike
  • Land -> Land

@mhsr21
Copy link
Author

mhsr21 commented May 7, 2024

@mtmail Some of the duplicates were present before my contribution--should I remove them altogether?

@mtmail
Copy link
Collaborator

mtmail commented May 7, 2024

@mhsr21 Would be great if you can remove the other duplicates, too. I see 42, and 41 of those are in the variants-en.yaml file.

cat settings/icu-rules/variants-* | perl -ne '/^\s+-\s+(.+?)\s+->\s+(.+)/ && $1 eq $2 && print' | wc -l
      42

@mhsr21
Copy link
Author

mhsr21 commented May 7, 2024

@mtmail Got rid of all duplicates in variants-en.yaml, plus the other one in variants-fr.yaml

Copy link
Member

@lonvia lonvia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for going through this. I agree that we should have official abbreviations in this list.

On a more general note, the US abbreviation list has always had the problem that it is far too long. In particular, it has the problem that it proposes sometimes 3 or 4 variants for the same word. This has a negative effect on the size of the index. Would it make sense to restrict ourselves to the official abbreviations only or are the other ones are just as frequently used?

- Spur -> Spur
- Spring -> Spg
- Springs -> Spgs
- SPurs -> Spur
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor typo here.

@mhsr21
Copy link
Author

mhsr21 commented May 18, 2024

Thanks for going through this. I agree that we should have official abbreviations in this list.

On a more general note, the US abbreviation list has always had the problem that it is far too long. In particular, it has the problem that it proposes sometimes 3 or 4 variants for the same word. This has a negative effect on the size of the index. Would it make sense to restrict ourselves to the official abbreviations only or are the other ones are just as frequently used?

I only added the official abbreviations (the rightmost column on the linked website).
Edit: I also fixed the typo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants