Fix handling of HTTP errors for replication handler #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Requests does not throw on HTTP errors, so pyosmium was just consuming the error message. Fix that. Also add a retry mechanism for transient errors. The list of transient status codes is the same as the one that curl uses.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When switching to the requests library,
open_urlceased to throw an exception on HTTP errors because requests behaves differently than urllib. This adds an explicitraise_for_status()call to bring the exceptions back.Also adds a retry handler from urllib3 to implicitly retry on transient HTTP errors. There is a fixed number of 3 retries and the list of status codes that are considered transient is the same as the one curl uses.
Switch the tests for replication to run against a local HTTP test server, so that the test cover the behaviour of request as well.
Fixes #235.