Generalize osmium.apply() to work with an arbitrary number of handlers #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The only other child class WriteHandler uses a different implementation for apply, so the generic variant is pointless.
That way, it can be used with generic apply functions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reworks the apply() function to use an indirect handler that can handle a vector of BaseHandlers. This way, an arbitrary number of handlers can be chained in one apply.
NodeLocationForWays is now exposed through a wrapper class which also inherits from BaseHandler. This means we can get rid of the special treatment in apply(). The interface doesn't change except that there is a new functionality to switch off applying node locations to ways.call to