Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try to make documentation easier to follow #251

Merged
merged 3 commits into from
Jun 16, 2024
Merged

Conversation

matkoniecz
Copy link
Contributor

@matkoniecz matkoniecz commented Jun 14, 2024

Attempt to make documentation easier to follow.

Disclaimer: I am not 100% is it a good advice but once I did it things started to work.

At least for me it was not obvious what should be put there, especially as

Downloading and adding libosmium sources from https://github.com/osmcode/libosmium/archive/v2.20.0.tar.gz
Downloading and adding protozero sources from https://github.com/mapbox/protozero/archive/v1.7.1.tar.gz
Downloading and adding pybind11 sources from https://github.com/pybind/pybind11/archive/v2.11.1.tar.gz

was seen in logs, shortly before erroring out (but for some reason this manual cloning repositories was still needed).

Done as part of #230 in hope that such PR (like some my recent PRs in related repos) are more useful than annoying.

Attempt to make documentation easier to follow.
@matkoniecz
Copy link
Contributor Author

To be more specific:

mateusz@grima:~/Documents/install/pyosmium/dist$ python3.8 -m pip install --user *.whl

worked fine and I have now working example code (yay)

while

mateusz@grima:~/Documents/install/pyosmium/dist$ python3.10 -m pip install --user *.whl
ERROR: osmium-3.7.0-cp38-cp38-linux_x86_64.whl is not a supported wheel on this platform.

failed with unclear error (see pypa/pip#10793 ) - so maybe that advise above is actually wrong and I should have done something else?

@lonvia
Copy link
Member

lonvia commented Jun 15, 2024

That's a good addition. Do you also want to add the commands to execute for the cloning to copy&paste for the next person? They should remain fairly stable.

@matkoniecz
Copy link
Contributor Author

matkoniecz commented Jun 15, 2024

I had another thought (though implementing this is likely beyond my abilities right now, I know nothing about cmake) - but is there reason why build process cannot do this? Why it needs to be done manually?

Or is it simply case of "nice to have, will not code itself on its own"

@matkoniecz
Copy link
Contributor Author

Do you also want to add the commands to execute for the cloning to copy&paste for the next person? They should remain fairly stable.

Done (though from memory, not tested them)

@lonvia
Copy link
Member

lonvia commented Jun 16, 2024

The build process does it by itself. It downloads the released version of the libraries as per src/osmium/version.py and properly puts everything into the source package. It's only when you run in development mode (i.e. build locally) that you need the links.

@lonvia lonvia merged commit 5df58fe into osmcode:master Jun 16, 2024
21 checks passed
@matkoniecz matkoniecz deleted the patch-2 branch June 16, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants