Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Location marker jumps back to place node when only partial location was given #127

Closed
daganzdaanda opened this issue Oct 28, 2023 · 3 comments

Comments

@daganzdaanda
Copy link

To reproduce:

  1. Enter a partial location in the first field (Start by telling us where your business is located), e.g. the town or city or state or country and press "Find me"
  2. The response "Found it! Move the marker until it is exactly on your business." shows up, as well as the warning about the missing house number.
  3. Try to drag the marker to anywhere
  4. It will always jump back to the initial position where the place=* node happens to be.

Found on Windows in a variety of browsers.

This may very well be behind a lot of misplaced notes! (see #103 #121 #124 )

@map-per
Copy link

map-per commented Nov 9, 2023

For the search terms "Iran" and "Teheran" the locations onosm.org shows are exactly the places where OSM notes are stackpiled.

@iandees
Copy link
Member

iandees commented Jan 29, 2024

I believe I solved this with 0b32e6a. There was an exception getting swallowed that caused the pin to revert back to the default location once dragged. There was also a bug that enabled the button to continue in this case.

I'm not able to reproduce the problem as described after this commit, so please give it a try and let me know.

@iandees iandees closed this as completed Jan 29, 2024
@daganzdaanda
Copy link
Author

Great, looks fine now!
We will see if that was the main issue that led to the hundreds of notes stacked on city place nodes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants