Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rephrase note_body to make some keys copyable #99

Open
wants to merge 1 commit into
base: gh-pages
Choose a base branch
from
Open

Rephrase note_body to make some keys copyable #99

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 11 additions & 10 deletions js/site.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,16 +128,17 @@ $("#collect-data-done").click(function() {
location.hash = '#done';

var note_body =
"onosm.org submitted note from a business:\n" +
"name: " + $("#name").val() + "\n" +
"phone: " + $("#phone").val() + "\n" +
"website: " + $("#website").val() + "\n" +
"twitter: " + $("#twitter").val() + "\n" +
"facebook: " + $("#facebook").val() + "\n" +
"email: " + $("#email").val() + "\n" +
"hours: " + $("#opening_hours").val() + "\n" +
"category: " + $("#category").val().join(", ") + "\n" +
"address: " + $("#address").val(),
"onosm.org submitted note from a business:\n\n" +
"name=" + $("#name").val() + "\n" +
"website=" + $("#website").val() + "\n" +
"phone=" + $("#phone").val() + "\n" +
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By the way, this field probably requires the reviewer’s attention too, because the country and area code may be missing: #94. That said, phone numbers needing additional formatting are quite common in OSM anyways.

Copy link
Author

@JesseWeinstein JesseWeinstein Mar 9, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, there are a bunch of formatting adjustments that ideally would be done in the onosm code at the time the data was submitted -- things like: "Did you forget the area code?" and converting @blahblah into "https://twitter.com/blahblah". But as you said, mis-formatted values are pretty common, so it seemed safe enough to allow for copy/paste for them.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is why I have generally been opposed to direct "copy paste" support. The values are almost never directly pastable, and I don't want to encourage adding bad data to OSM. If a mapper doesn't want to take the time to research a submission from onosm with first-hand data, they should leave it as-is and move on.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name value is nearly always copy-pastable, as is the website, and in most cases, the twitter and facebook. Researching is certainly needed, but not to replace these values, but to confirm the existence and location of the business. And people will still copy paste even if you use colons rather than equals signs, it'll just add a bit of extra work for no purpose.

"twitter=" + $("#twitter").val() + "\n" +
"facebook=" + $("#facebook").val() + "\n\n" +
"Other info (Needs to be adapted to OSM tagging standards):\n" +
" Address: " + $("#address").val() + "\n" +
" Hours: " + $("#opening_hours").val() + "\n" +
" Category: " + $("#category").val().join(", ") + "\n" +
" Email: " + $("#email").val(),
latlon = findme_marker.getLatLng(),
note_data = {
lat: latlon.lat,
Expand Down