Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add min swap amount to each host zone config for improve cross chain swap call #171

Merged
merged 7 commits into from
Mar 27, 2024

Conversation

tnv1
Copy link
Collaborator

@tnv1 tnv1 commented Mar 18, 2024

Closed #155.

@tnv1 tnv1 requested a review from nghuyenthevinh2000 March 18, 2024 05:32
@nghuyenthevinh2000
Copy link
Member

Please provide relevant tests for logic

@tuantran1702
Copy link
Collaborator

I wonder why we have two instances of HostChainFeeAbsConfig in both interchaintest and x/feeabs package? What is the context behind this? @tnv1 @nghuyenthevinh2000

@nghuyenthevinh2000
Copy link
Member

I wonder why we have two instances of HostChainFeeAbsConfig in both interchaintest and x/feeabs package? What is the context behind this? @tnv1 @nghuyenthevinh2000

That is due to json unmarshall structure, field pool id in feeabs is uint, which json string cannot be unmarshaled into, thus needed a string field

@tuantran1702 tuantran1702 enabled auto-merge (squash) March 27, 2024 07:16
@tuantran1702 tuantran1702 self-requested a review March 27, 2024 11:17
@tuantran1702 tuantran1702 merged commit afe5e17 into main Mar 27, 2024
13 checks passed
@nghuyenthevinh2000
Copy link
Member

@tropicaldog you forgot to add a success case

@tuantran1702 tuantran1702 deleted the swapcall branch May 6, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve crosschain swap call
3 participants