Fix: Fix workflow to run all interchaintest tests as expected #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I also detect missing checks for feeabs in TestQueryOsmosisTwap, result from querying feeabs is not checked: https://github.com/osmosis-labs/fee-abstraction/blob/main/tests/interchaintest/query_osmosis_twap_test.go#L115 probably due to this one #125 
|
|
This is the error when executing feeabs wasm msg 
|
I think the channel id should be registered in the registry contract first. |
tuantran1702
changed the title
tuantran1702
changed the title
2 tasks
it is gas problem, I have fixed that one |
nghuyenthevinh2000
approved these changes
Mar 23, 2024
tnv1
pushed a commit
that referenced
this pull request
Mar 27, 2024
* fix running wrong test in Makefile, also catching bug when upload contract * add missing field in init message of xcsV2 * fix interchaintest * fix interchaintest ictest-ibc --------- Co-authored-by: nghuyenthevinh2000 <[email protected]>
tnv1
added a commit
that referenced
this pull request
Apr 22, 2024
* Draft upgrate to cosmos-sdk v0.50 and ibc-go v8 * Change dependencies compatible with cosmos-sdk 0.50 * Change Dec to LegacyDec * Fix some lints * Fix bugs * Fix test and lint * Fix: Fix workflow to run all interchaintest tests as expected (#174) * fix running wrong test in Makefile, also catching bug when upload contract * add missing field in init message of xcsV2 * fix interchaintest * fix interchaintest ictest-ibc --------- Co-authored-by: nghuyenthevinh2000 <[email protected]> * Fix conflicts * Go mod tidy * Make lint * Update interchaintest * Fix linys * Fix dockerfile * Fix bech32 addr prefix * Fix interchaintest * Fix missing light clients * Fix lint --------- Co-authored-by: Tuan Tran <[email protected]> Co-authored-by: nghuyenthevinh2000 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #175
Changes
Currently
make ictest-feeabsandmake ictest-ibcare running the sameTestFeeabsGaiaIBCTransfer, and theTestFeeAbsin feeabs_test.go is ignored because it doesn't start withTestFeeabs, which cause misleading tests success.Now run the
TestFeeAbsby exact match to save time, not sure ifmake ictest-feeabsis intended to run both theTestFeeabsGaiaIBCTransferand theTestFeeAbs.After running the TestFeeAbs, an error occur related to contract instantiation. Fixed by using correct code id when instantiate contract.