Test: add unit tests for decorators #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tuantran1702
commented
Apr 8, 2024
| if !feeCoins.IsAnyGTE(nonZeroCoinFeesReq) { | ||
| err := sdkerrors.Wrapf(errorstypes.ErrInsufficientFee, "insufficient fees; got: %s required: %s", feeCoins, feeRequired) | ||
| if !feeCoinsNonZeroDenom.IsAnyGTE(nonZeroCoinFeesReq) { | ||
| err := sdkerrors.Wrapf(errorstypes.ErrInsufficientFee, "insufficient fees; got: %s required: %s", feeCoinsNonZeroDenom, nonZeroCoinFeesReq) |
There was a problem hiding this comment.
feeCoins is the initial fees(which might be an ibc denom), so when compare to nonZeroCoinFeeReq, which are the amount of fee required in native token, would fail if provided fee is IBC denom. feeCoinsNonZeroDenom is calculated from feeCoins and TwapPrices here, and also alway in native denom, so have to use it instead.
tuantran1702
force-pushed
the
tuan/add-ante-test
branch
from
f324217 to
639167f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.