Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix key and add time Infraction #172

Closed
wants to merge 5 commits into from
Closed

fix key and add time Infraction #172

wants to merge 5 commits into from

Conversation

likesToEatFish
Copy link
Contributor

maurolacy
maurolacy approved these changes Jul 3, 2024
View reviewed changes
Copy link
Collaborator

@maurolacy maurolacy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for this btw.

x/meshsecurity/keeper/adapter.go Outdated Show resolved Hide resolved
x/meshsecurity/types/keys.go Outdated Show resolved Hide resolved
x/meshsecurity/keeper/valset_updates.go Outdated Show resolved Hide resolved
x/meshsecurity/keeper/valset_updates_test.go Show resolved Hide resolved
x/meshsecurity/types/keys.go Outdated Show resolved Hide resolved
@maurolacy maurolacy requested a review from alpe July 3, 2024 09:58
@likesToEatFish
Copy link
Contributor Author

I just cleaned up BuildPipedValsetOpKey, please review again @maurolacy

@alpe
Copy link
Contributor

alpe commented Jul 15, 2024

Thanks for the PR. Unfortunately, I don't have capacity to work on this project. Not sure who is owning it now.

@likesToEatFish
Copy link
Contributor Author

I added it in #177 so I'm closing this PR

@maurolacy
Copy link
Collaborator

k, I also don't have capacity for this atm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maurolacy maurolacy maurolacy approved these changes

@alpe alpe Awaiting requested review from alpe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@likesToEatFish @alpe @maurolacy @DongLieu