-
Notifications
You must be signed in to change notification settings - Fork 416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Cosmostation mobile #3576
Conversation
Feature/resolve conflict
@G-Gamja is attempting to deploy a commit to the OsmoLabs Team on Vercel. A member of the Team first needs to authorize it. |
WalkthroughThe recent updates improve wallet functionality within the application by adding a Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant App
participant WalletRegistry
participant WalletSelector
User->>App: Open Wallet Selection
App->>WalletRegistry: Retrieve Wallet Configurations
WalletRegistry-->>App: Return Wallet Configurations
App->>WalletSelector: Select Wallets
alt Cosmostation App Detected
WalletSelector->>WalletSelector: Filter to only include Cosmostation wallet
else Other App
WalletSelector->>WalletSelector: Show all available wallets
end
WalletSelector-->>App: Display Filtered Wallets
App-->>User: Show Wallet Options
Recent review detailsConfiguration used: CodeRabbit UI Files selected for processing (1)
Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@G-Gamja not seeing Cosmostation option on mobile. |
@CryptoAssassin1 Thank you for reviewing this PR. This PR includes the implementation that allows connecting the wallet within our app's WebView. We will also check if it is possible to connect the wallet in non-WebView environments using the WalletConnect feature. |
@G-Gamja is it possible for us to test it? |
@CryptoAssassin1 You can test by entering the local dev URL of the Osmosis front end in the Dev Mode under the Settings tab. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working fine.
We have resolved the Node.js version issue from the previous PR and submitted a new PR. Please review it.
What is the purpose of the change:
support Cosmostation app wallet in Connect wallet popup component
Linear Task
previous PR
Brief Changelog
Testing and Verifying