Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Cosmostation mobile #3576

Merged
merged 9 commits into from
Oct 8, 2024
Merged

feat: Cosmostation mobile #3576

merged 9 commits into from
Oct 8, 2024

Conversation

G-Gamja
Copy link
Contributor

@G-Gamja G-Gamja commented Jul 22, 2024

We have resolved the Node.js version issue from the previous PR and submitted a new PR. Please review it.

What is the purpose of the change:

support Cosmostation app wallet in Connect wallet popup component

Linear Task

previous PR

Brief Changelog

  • This supports connect Cosmostation app wallet feature

Testing and Verifying

  • This change has been tested locally by rebuilding the website with the Cosmostation app wallet (iOS and Android market versions).

Copy link

vercel bot commented Jul 22, 2024

@G-Gamja is attempting to deploy a commit to the OsmoLabs Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

coderabbitai bot commented Jul 22, 2024

Walkthrough

The recent updates improve wallet functionality within the application by adding a mobileDisabled property to the wallet configuration, indicating if mobile use is enabled. Additionally, new conditional logic was introduced to filter wallet options for users accessing the app via the Cosmostation in-app browser, thus enhancing the wallet selection process for mobile users.

Changes

File Path Change Summary
packages/web/config/wallet-registry.ts Added mobileDisabled: boolean to the wallet configuration object in CosmosWalletRegistry, indicating mobile functionality availability.
packages/web/modals/wallet-select/use-selectable-wallets.ts Introduced conditional logic in useSelectableWallets to filter wallet options for users accessing via the Cosmostation app, ensuring tailored wallet selection.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant App
    participant WalletRegistry
    participant WalletSelector

    User->>App: Open Wallet Selection
    App->>WalletRegistry: Retrieve Wallet Configurations
    WalletRegistry-->>App: Return Wallet Configurations
    App->>WalletSelector: Select Wallets
    alt Cosmostation App Detected
        WalletSelector->>WalletSelector: Filter to only include Cosmostation wallet
    else Other App
        WalletSelector->>WalletSelector: Show all available wallets
    end
    WalletSelector-->>App: Display Filtered Wallets
    App-->>User: Show Wallet Options
Loading

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 037f822 and 94382be.

Files selected for processing (1)
  • packages/web/modals/wallet-select/use-selectable-wallets.ts (1 hunks)
Files skipped from review as they are similar to previous changes (1)
  • packages/web/modals/wallet-select/use-selectable-wallets.ts

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

vercel bot commented Jul 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
osmosis-frontend ❌ Failed (Inspect) Oct 8, 2024 3:29am

@CryptoAssassin1
Copy link
Member

@G-Gamja not seeing Cosmostation option on mobile.
image

@G-Gamja
Copy link
Contributor Author

G-Gamja commented Jul 23, 2024

@CryptoAssassin1 Thank you for reviewing this PR.

This PR includes the implementation that allows connecting the wallet within our app's WebView. We will also check if it is possible to connect the wallet in non-WebView environments using the WalletConnect feature.

@CryptoAssassin1
Copy link
Member

@G-Gamja is it possible for us to test it?

@G-Gamja
Copy link
Contributor Author

G-Gamja commented Jul 24, 2024

@CryptoAssassin1 You can test by entering the local dev URL of the Osmosis front end in the Dev Mode under the Settings tab.

IMG_3F4AE72ABBCE-1

Copy link
Member

@CryptoAssassin1 CryptoAssassin1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working fine.

@jonator jonator requested a review from a team October 8, 2024 03:23
@jonator jonator changed the title feat: Suppport Cosmostation app wallet feat: Cosmostation mobile Oct 8, 2024
@jonator jonator merged commit 2291cff into osmosis-labs:stage Oct 8, 2024
1 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants