Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable OKTO Wallet Official Support on Osmosis #3714

Open
wants to merge 4 commits into
base: stage
Choose a base branch
from

Conversation

SrijanCoinDCX
Copy link

What is the purpose of the change:
This PR introduces official support for the OKTO wallet on the Osmosis platform. By integrating OKTO wallet, we aim to enhance user experience and expand accessibility to the Osmosis ecosystem.

Linear Task
Link to Linear Task

Brief Changelog

  • Integrated OKTO wallet into the Cosmos-kit.
  • Imported the wallet into the Web package.
  • Added OKTO wallet to the generated wallet list.

Testing and Verifying
This change has been tested locally by rebuilding the website and verified content and links are expected.

Copy link

vercel bot commented Aug 9, 2024

@SrijanCoinDCX is attempting to deploy a commit to the OsmoLabs Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

coderabbitai bot commented Aug 9, 2024

Walkthrough

The updates introduce support for the Okto wallet extension in the Cosmos wallet ecosystem. This involves enhancing the CosmosKitWalletList to include the Okto wallet and adding a corresponding entry in the CosmosWalletRegistry. These changes expand the options available to users without affecting existing functionality, thereby enriching the overall wallet integration.

Changes

File(s) Change Summary
packages/web/config/generate-cosmos-kit-wallet-list.ts
packages/web/config/wallet-registry.ts
Added support for the Okto wallet extension by including it in both the CosmosKitWalletList and the CosmosWalletRegistry. This includes a new entry with properties such as logo URL, mobile installation flag, lazy loading function, and features.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant WalletList
    participant WalletRegistry

    User->>WalletList: Request wallet options
    WalletList-->>User: Return list of wallets (includes Okto)
    
    User->>WalletRegistry: Select Okto wallet
    WalletRegistry->>User: Load Okto wallet features
Loading

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Outside diff range, codebase verification and nitpick comments (1)
packages/web/config/wallet-registry.ts (1)

157-165: Missing Dependency for OKTO Wallet Entry

The @cosmos-kit/okto-extension package is not listed as a dependency in package.json, which may cause the lazy loading function to fail at runtime. Ensure that this package is added to the project's dependencies to resolve the issue.

  • Add @cosmos-kit/okto-extension to the package.json dependencies.
Analysis chain

Addition of OKTO wallet entry is well-structured.

The new entry for the OKTO wallet is consistent with existing entries in the CosmosWalletRegistry. The properties are correctly set, including lazy loading and features.

Verify that the logo path and lazy loading function are correct.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the logo path and lazy loading function for the OKTO wallet entry.

# Test: Check if the logo file exists. Expect: The file `/wallets/okto.png` should exist.
if [ ! -f "packages/web/public/wallets/okto.png" ]; then
  echo "Logo file for OKTO wallet is missing."
else
  echo "Logo file for OKTO wallet is present."
fi

# Test: Verify the lazy loading function. Expect: The function should correctly import the `OktoExtensionWallet`.
ast-grep --lang typescript --pattern 'export const OktoExtensionWallet = $_;' @cosmos-kit/okto-extension

Length of output: 319


Script:

#!/bin/bash
# Check if @cosmos-kit/okto-extension is listed as a dependency in package.json
if grep -q '"@cosmos-kit/okto-extension"' package.json; then
  echo "@cosmos-kit/okto-extension is listed as a dependency."
else
  echo "@cosmos-kit/okto-extension is not listed as a dependency."
fi

# Verify the import path for @cosmos-kit/okto-extension in the codebase
rg --glob '!node_modules/*' '@cosmos-kit/okto-extension' -A 2

Length of output: 909

Copy link

vercel bot commented Aug 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
osmosis-frontend ❌ Failed (Inspect) Aug 20, 2024 3:04pm

@JoseRFelix
Copy link
Collaborator

@SrijanCoinDCX Thank you for opening this PR! The build is failing. Could you merge with stage? That should fix it

@SrijanCoinDCX
Copy link
Author

Hi, @JoseRFelix . Thank you for your response. I have synced my PR with stage, as you advised; could you please review it again?

@MaxMillington
Copy link
Collaborator

Screenshot 2024-08-20 at 9 27 53 AM @SrijanCoinDCX looks like the build is still failing. I would rebase with stage, clear out everything and reinstall.

@SrijanCoinDCX
Copy link
Author

Okay, @MaxMillington, let me know if anything needs to be fixed or improved on my end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants