Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mattupham/fe 725 porfolio v3 variants detected popup #3871

Open
wants to merge 17 commits into
base: stage
Choose a base branch
from
Open

Mattupham/fe 725 porfolio v3 variants detected popup #3871

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
3d8f1f2
feat(global): add alloyed assets popup
mattupham Sep 26, 2024
827ff3a
feat(Alloyed-assets-popup-modal): add popup modal with icons
mattupham Sep 30, 2024
b94ee34
Merge branch 'stage' into mattupham/fe-725-porfolio-v3-variants-detec…
mattupham Oct 2, 2024
d6a455c
feat(variants-detected): finalize styles
mattupham Oct 2, 2024
cfd9dcb
feat(variants-detected): i18n
mattupham Oct 2, 2024
59ee4e3
feat(getHasAssetVariants): add query to fetch and calculate if user h…
mattupham Oct 4, 2024
59a79ff
feat(alloyed-assets-variants-detected): update toast options for toas…
mattupham Oct 7, 2024
99f560f
test(Allocation): Add tests for Has Asset Variants
mattupham Oct 7, 2024
5511741
test(Allocation): Add test for if user has no assets
mattupham Oct 7, 2024
8e0796a
build(i18n): add translations
mattupham Oct 7, 2024
070cc05
refactor(alloyed-assets-variants-detection): clean up
mattupham Oct 7, 2024
d42b364
refactor(alloyed-assets-variants-detection): optimize function with g…
mattupham Oct 7, 2024
bb4b8a1
fix(getHasAssetVariants): only enable if wallet is not loading
mattupham Oct 7, 2024
2983ccc
fix(getHasAssetVariants): handle cases where wallet is loading and wa…
mattupham Oct 7, 2024
39c1943
Prevent call to SQS (#3872)
jonator Oct 7, 2024
daad653
docs(alloyed-asset-variants): add comment for checking for alloyed as…
mattupham Oct 7, 2024
58aa1e9
docs(asset-variants): update asset variants comment
mattupham Oct 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/server/src/queries/complex/portfolio/allocation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,11 +168,12 @@ export async function getAllocation({
new Dec(categories["total-assets"].capitalization)
);

// Check for variants
const userBalanceDenoms =
categories["user-balances"]?.account_coins_result?.map(
(result) => result.coin.denom
) ?? [];

// check for alloyed asset variants
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Giga Nit: variants include canonical assets such as USDC, not just alloys

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ha updated that comment for clarity

const hasVariants = checkHasAssetVariants(
userBalanceDenoms,
assetLists.flatMap((list) => list.assets)
Expand Down