Merge pull request #101 from osmosis-labs/fix/add-version-comparison

Update update-version.yaml
osmosis-labs · Jul 3, 2024 · 6d686e8 · 6d686e8
2 parents 56f2492 + 5fd84d3
commit 6d686e8
Showing 1 changed file with 64 additions and 6 deletions.
diff --git a/.github/workflows/update-version.yaml b/.github/workflows/update-version.yaml
@@ -38,19 +38,49 @@ jobs:
           exit 1
         fi
 
+    - name: Compare versions
+      id: compare_versions
+      run: |
+        compare_versions() {
+          local v1=$1
+          local v2=$2
+          if [[ $v1 == $v2 ]]; then
+            echo "COMPARE_RESULT=0" >> $GITHUB_ENV
+            return
+          fi
+          local IFS=.
+          local i
+          local version1=($v1)
+          local version2=($v2)
+          for ((i=0; i<${#version1[@]}; i++)); do
+            if [[ ${version1[i]} -gt ${version2[i]} ]]; then
+              echo "COMPARE_RESULT=1" >> $GITHUB_ENV
+              return
+            fi
+            if [[ ${version1[i]} -lt ${version2[i]} ]]; then
+              echo "COMPARE_RESULT=2" >> $GITHUB_ENV
+              return
+            fi
+          done
+          echo "COMPARE_RESULT=0" >> $GITHUB_ENV
+        }
+
+        compare_versions ${{ env.NETWORK_VERSION }} ${{ env.FILE_VERSION }}
+
     - name: Generate branch name
+      if: env.COMPARE_RESULT == 1
       run: |
         RANDOM_ID=$(openssl rand -hex 6)
         BRANCH_NAME="UPDATE-${{ env.VERSION_VAR }}-TO-${{ env.NETWORK_VERSION }}-$RANDOM_ID"
         echo "BRANCH_NAME=$BRANCH_NAME" >> $GITHUB_ENV
 
     - name: Update version if different
-      if: env.NETWORK_VERSION != env.FILE_VERSION
+      if: env.COMPARE_RESULT == 1
       run: |
         sed -i "s/${{ env.VERSION_VAR }} = \".*\"/${{ env.VERSION_VAR }} = \"${{ env.NETWORK_VERSION }}\"/" i.py
 
     - name: Create Pull Request
-      if: env.NETWORK_VERSION != env.FILE_VERSION
+      if: env.COMPARE_RESULT == 1
       uses: peter-evans/create-pull-request@v6
       with:
         token: ${{ secrets.GITHUB_TOKEN }}
@@ -64,7 +94,6 @@ jobs:
           🤖 This PR was autogenerated.
 
 
-
   update-mainnet-version:
     runs-on: ubuntu-latest
     env:
@@ -82,7 +111,6 @@ jobs:
         echo "NETWORK_VERSION=$NETWORK_VERSION" >> $GITHUB_ENV
 
     - name: Get current version from file
-      id: get_file_version
       run: |
         FILE_VERSION=$(grep '${{ env.VERSION_VAR }}' i.py | cut -d'"' -f2 | head -n 1)
         echo "FILE_VERSION=$FILE_VERSION" >> $GITHUB_ENV
@@ -94,19 +122,49 @@ jobs:
           exit 1
         fi
 
+    - name: Compare versions
+      id: compare_versions
+      run: |
+        compare_versions() {
+          local v1=$1
+          local v2=$2
+          if [[ $v1 == $v2 ]]; then
+            echo "COMPARE_RESULT=0" >> $GITHUB_ENV
+            return
+          fi
+          local IFS=.
+          local i
+          local version1=($v1)
+          local version2=($v2)
+          for ((i=0; i<${#version1[@]}; i++)); do
+            if [[ ${version1[i]} -gt ${version2[i]} ]]; then
+              echo "COMPARE_RESULT=1" >> $GITHUB_ENV
+              return
+            fi
+            if [[ ${version1[i]} -lt ${version2[i]} ]]; then
+              echo "COMPARE_RESULT=2" >> $GITHUB_ENV
+              return
+            fi
+          done
+          echo "COMPARE_RESULT=0" >> $GITHUB_ENV
+        }
+
+        compare_versions ${{ env.NETWORK_VERSION }} ${{ env.FILE_VERSION }}
+
     - name: Generate branch name
+      if: env.COMPARE_RESULT == 1
       run: |
         RANDOM_ID=$(openssl rand -hex 6)
         BRANCH_NAME="UPDATE-${{ env.VERSION_VAR }}-TO-${{ env.NETWORK_VERSION }}-$RANDOM_ID"
         echo "BRANCH_NAME=$BRANCH_NAME" >> $GITHUB_ENV
 
     - name: Update version if different
-      if: env.NETWORK_VERSION != env.FILE_VERSION
+      if: env.COMPARE_RESULT == 1
       run: |
         sed -i "s/${{ env.VERSION_VAR }} = \".*\"/${{ env.VERSION_VAR }} = \"${{ env.NETWORK_VERSION }}\"/" i.py
 
     - name: Create Pull Request
-      if: env.NETWORK_VERSION != env.FILE_VERSION
+      if: env.COMPARE_RESULT == 1
       uses: peter-evans/create-pull-request@v6
       with:
         token: ${{ secrets.GITHUB_TOKEN }}