Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQS-404 | E2E Tests: Compute liquidity with CoinGecko ( backport ) #516

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

deividaspetraitis
Copy link
Collaborator

@deividaspetraitis deividaspetraitis commented Sep 18, 2024

This PR adds COINGECKO_API_KEY env variable for E2E tests to enable computing liquidity with CoinGecko instead of Numia

Summary by CodeRabbit

  • New Features

    • Integration tests now utilize the CoinGecko API for enhanced cryptocurrency functionality validation.
  • Bug Fixes

    • Improved testing capabilities by allowing integration tests to interact with external services.

This PR adds COINGECKO_API_KEY env variable for E2E tests to enable computing liquidity with CoinGecko instead of Numia
Copy link
Contributor

coderabbitai bot commented Sep 18, 2024

Walkthrough

The changes involve the addition of the COINGECKO_API_KEY environment variable in the .github/workflows/integration-test.yml file. This variable is now included in both the integration_test and scheduled_integration_test jobs, indicating that these tests will have access to the CoinGecko API for cryptocurrency-related functionalities.

Changes

File Change Summary
.github/workflows/integration-test.yml Added COINGECKO_API_KEY to environment variables for integration_test and scheduled_integration_test jobs.

Possibly related PRs

Suggested labels

A:backport/v26.x

Suggested reviewers

  • p0mvn
  • alessandrolomanto
  • cryptomatictrader

🐇 In the garden where bunnies play,
A new key hops in to save the day.
With CoinGecko's help, tests will soar,
Validating data like never before!
So let us cheer for this API,
As integration tests reach for the sky! 🌟


Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between e60a025 and e62efad.

Files selected for processing (1)
  • .github/workflows/integration-test.yml (2 hunks)
Additional comments not posted (2)
.github/workflows/integration-test.yml (2)

46-46: LGTM!

The addition of the COINGECKO_API_KEY environment variable sourced from the repository's secrets is a good practice. It enables the integration tests to interact with the CoinGecko API securely, which aligns with the PR objective of computing liquidity using CoinGecko.


77-77: Looks good!

The addition of the COINGECKO_API_KEY environment variable to the scheduled_integration_test job is consistent with the changes made to the integration_test job. This ensures that both manual and scheduled tests have access to the CoinGecko API, which is necessary for computing liquidity as per the PR objectives.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    -- I pushed a fix in commit <commit_id>, please review it.
    -- Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    -- @coderabbitai generate unit testing code for this file.
    -- @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    -- @coderabbitai generate interesting stats about this repository and render them as a table.
    -- @coderabbitai read src/utils.ts and generate unit testing code.
    -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@deividaspetraitis deividaspetraitis changed the title SQS-393 | E2E Tests: Compute liquidity with CoinGecko ( backport ) SQS-404 | E2E Tests: Compute liquidity with CoinGecko ( backport ) Sep 18, 2024
@deividaspetraitis deividaspetraitis merged commit dd03e56 into v26.x Sep 18, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant