-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SQS-406 | E2E Tests: Increase expected latency upper bound for /passthrough/active-orders enpoind ( backport ) #517
Conversation
/passthrough/active-orders enpoint This PR Increases latency upper bound from 150ms to 450ms based on our current observations via monitoring tools to make tests less noisy.
WalkthroughThe pull request modifies the constant Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Outside diff range and nitpick comments (1)
tests/test_passthrough.py (1)
12-12
: Approve the latency upper bound adjustment.The change to increase the
EXPECTED_LATENCY_UPPER_BOUND_MS
from 150 to 450 aligns with the PR objective to adjust the expected latency upper bound for the/passthrough/active-orders
endpoint based on current observations. This adjustment aims to create a more stable testing environment by accommodating the observed latency variations, thereby reducing false negatives in test results.Consider adding a comment to explain the reason for the change and the source of the new value. For example:
# Increased the expected latency upper bound from 150 to 450 ms based on # current observations gathered through monitoring tools. This adjustment # aims to create a more stable testing environment by accommodating the # observed latency variations. EXPECTED_LATENCY_UPPER_BOUND_MS = 450Additionally, it is recommended to monitor the latency after the change to ensure it remains within the new upper bound. If the latency consistently exceeds the new threshold, further investigation and optimization may be required.
This PR Increases latency upper bound from 150ms to 450ms based on our current observations via monitoring tools to make tests less noisy.
Summary by CodeRabbit