Unit test for host scanner added #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
guyluz11
reviewed
Mar 3, 2023
| .thenAnswer((_) => Stream.value(activeHost)); | ||
| expect( | ||
| mockHostScanner.getAllPingableDevices("10.0.0"), | ||
| emits(ActiveHost(internetAddress: InternetAddress("10.0.0.1"))), |
There was a problem hiding this comment.
Does it pass in GitHub action even though it could be different IP?
There was a problem hiding this comment.
Fetching interface address and pinging own machine. Check now @guyluz11
There was a problem hiding this comment.
I'll add more cases in this PR only later.
git-elliot
changed the title
guyluz11
reviewed
Mar 4, 2023
| emits(isA<ActiveHost>()), | ||
| ); | ||
| }); | ||
|
|
||
| test('Running getMaxHost tests', () { | ||
| expect(HostScanner.getMaxHost("10.0.0.0"), HostScanner.classASubnets); |
There was a problem hiding this comment.
Isn't it supposed to be 127.0.0.254 ?
There was a problem hiding this comment.
this function uses first octet of IPV4 to check for Subnet class. Success cases are added as of now. Will add more case where it cover cases like "10.0.0.0" can't be classB address.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added for all methods of Host Scanner.
Completed mostly all cases for getMaxHost
At least one case of getAllPingableDevices and scanDevicesForSinglePort