Handle 307 redirects in hc-login (#35) #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Had the same issue too. Testing is tricky but the code looks fine and does not break something else. |
|
I agree that testing is a problem. I was not able to find any documentation for singlekey-id.com, so best I can do is assume they strictly follow Oauth. But Oauth should never return a 307, so I'm slightly confused there. In either case the hc-login script doesn't finish successfully for me. So I can't guarantee that 307 forward does/doesn't get me closer to a working setup. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Properly handle
307redirects, in the same way302redirects are already handled. See issue #35 and https://en.wikipedia.org/wiki/List_of_HTTP_status_codes#3xx_redirection.