Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set the defaults argument to None to fix dangerous-default-value linter warning #286

Closed
wants to merge 1 commit into from
Closed

Set the defaults argument to None to fix dangerous-default-value linter warning #286

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/rocker/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,9 @@ def check_args_for_activation(cls, cli_args):
return True if cli_args.get(cls.get_name()) else False

@staticmethod
def register_arguments(parser, defaults={}):
def register_arguments(parser, defaults:dict=None):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
def register_arguments(parser, defaults:dict=None):
def register_arguments(parser, defaults: dict=None):

Need a space for readability.

if defaults is None:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When the user overrides this function this won't be called.

defaults={}
raise NotImplementedError


Expand Down
Loading