Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding 2022 elements to vrx.launch #359

Merged
merged 2 commits into from
Sep 11, 2021
Merged

Conversation

M1chaelM
Copy link
Collaborator

This resolves issue #279

To test, run:

roslaunch vrx_gazebo vrx.launch

You should see the light buoy, docks, gymkhana course and our 3 animals:

vrx_2022_launch

@bsb808
Copy link
Collaborator

bsb808 commented Sep 11, 2021

I think we need to first address PRs #354 and #358 - then when those are merged, rebase this branch to see if it still works as expected. I suspect that the model poses will need to be modified.

@M1chaelM
Copy link
Collaborator Author

I think we need to first address PRs #354 and #358 - then when those are merged, rebase this branch to see if it still works as expected. I suspect that the model poses will need to be modified.

@bsb808 Sure, I can take a look at those now. That said, I have already created this file and it appears to be working, so I think it would be safe to go ahead and approve. If changes are needed I will add them as part of the PR that introduces the need for new poses. Is there any downside to this?

@bsb808
Copy link
Collaborator

bsb808 commented Sep 11, 2021

I think we need to first address PRs #354 and #358 - then when those are merged, rebase this branch to see if it still works as expected. I suspect that the model poses will need to be modified.

@bsb808 Sure, I can take a look at those now. That said, I have already created this file and it appears to be working, so I think it would be safe to go ahead and approve. If changes are needed I will add them as part of the PR that introduces the need for new poses. Is there any downside to this?

Just seems like a little more work to test this modification twice, once now and then again after we fix the coordinates.

Copy link
Collaborator

@bsb808 bsb808 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go for 1.5

@M1chaelM M1chaelM merged commit bd6c9cb into master Sep 11, 2021
@caguero caguero deleted the M1hchaelM/vrx_2022_demo_world branch January 5, 2023 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants