Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug solution multi-vehicles in wamv_gazebo.urdf.xacro #644

Merged
merged 6 commits into from
Jul 15, 2023

Conversation

carvee1
Copy link
Contributor

@carvee1 carvee1 commented May 16, 2023

When trying to launch a second vessel with the name wamv2, the following error message was shown
[ERROR] [launch]: Caught exception in launch (see debug for traceback): Error Code 20: Msg: Child frame with name[wamv/base_link] specified by joint with name[wamv_external_pivot_joint] not found in model with name[WAM-V]
When inspecting the problem (also see problem #638), I found the problem in line 103 of the wamv_gazebo.urdf.xacro file, in which the namespace was not properly referenced to the namespace but only to the standard topic namespace of wamv/base_link. As a result without changing the child to $(arg namespace)/base_link, it is not possible to spawn a second vehicle with a different namespace. Therefore, without the change, it would not be possible to control the vessels independent of each other, as both subscribe to the same topic.

Tested the changes for ROS2

When trying to launch a second vessel with the name wamv2, the following error message was shown
"[ERROR] [launch]: Caught exception in launch (see debug for traceback): Error Code 20: Msg: Child frame with name[wamv/base_link] specified by joint with name[wamv_external_pivot_joint] not found in model with name[WAM-V]"
The problem was found in line 103 of the wamv_gazebo.urdf.xacro file, in which the namespace was not properly referenced to the namespace but only to the standard topic namespace of "wamv/base_link". As a result without changing the child to "$(arg namespace)/base_link, it is not possible to spawn a second vehicle with a different namespace. Therefor, without the change, it would not be possible to control the vessels independent of each other, as both subscribe to the same topic.
@j-herman
Copy link
Collaborator

j-herman commented Jun 4, 2023

@M1chaelM @caguero - tested with locked and unlocked wamv, runs fine

@M1chaelM
Copy link
Collaborator

@caguero Do you want to merge this bug fix into our upcoming release? @j-herman has reviewed, and the code change looks pretty straightforward, so I thought we might want to consider it even though we aren't focused on supporting multiple vehicles.

@caguero caguero added this to the 2.3.1 milestone Jul 11, 2023
@caguero caguero requested a review from j-herman July 11, 2023 18:13
@caguero caguero merged commit e7dfeb2 into osrf:main Jul 15, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants