-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increasing obstacle penalty in acoustic tracking task #685
Conversation
Signed-off-by: Carlos Agüero <[email protected]>
This looks like a very straightforward change, so I'm not sure if it's related to the problems I'm experiencing, but it seems like too many collisions (or collisions that are too violent?) cause the simulation to crash. The error I get on runs with more than a couple collisions (e.g. 6-12) seems at least superficially to have something to do with collisions:
I also tried a run without moving the WAM-V at all and one with only 2 collisions and it didn't crash. |
I managed to reproduce this issue on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as expected. I ran the task to make sure the score was updated by the right value at the end. As a side note, I found it extremely difficult to complete this task without producing a crash, even when moving the WAMV very cautiously. Ultimately I gave up and just let the WAMV remain still after 10 very careful collisions with a buoy. My takeaway is that issue #690 is more important than I initially realized.
As discussed offline, we're bumping the penalty for hitting obstacles from
0.1m
to1m
.