Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix score in follow-the-path task #748

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Fix score in follow-the-path task #748

merged 1 commit into from
Oct 16, 2023

Conversation

caguero
Copy link
Contributor

@caguero caguero commented Oct 13, 2023

While running phase 2 I noticed an issue in the scoring of the follow-the-path task.

If the course isn't completed, the score is overwritten with the timeout score, that was initialized to 200. Now that the task grants points each time the vehicles crosses a gate, we shouldn't do anything special if the task timeouts. The score should be preserved.

How to test it?

Launch a follow-the-path task:

ros2 launch vrx_gz competition.launch.py world:=practice_2023_follow_path0_task

And then:

ros2 topic echo /vrx/task/info

If you don't cross any gates, the score should be 0 instead of 200.

Signed-off-by: Carlos Agüero <[email protected]>
@caguero caguero added this to the 2.3.3 milestone Oct 13, 2023
@j-herman
Copy link
Collaborator

I've reviewed this and it's working fine, but for some reason the button to submit the approval is hanging up. I'll try again later, but no need for anyone else to test this.

@caguero
Copy link
Contributor Author

caguero commented Oct 16, 2023

I've reviewed this and it's working fine, but for some reason the button to submit the approval is hanging up. I'll try again later, but no need for anyone else to test this.

Thanks! Merging then.

@caguero caguero merged commit f79b03f into main Oct 16, 2023
1 check passed
@caguero caguero deleted the caguero/follow_path_fix branch October 16, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants