Expand parameters for container image building #426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JAORMX
force-pushed
the
image-build-revamp
branch
2 times, most recently
from
bc19ebe to
28f63b4
Compare
This adds the following: * Expanded container metadata for the built image. * multi-architecture builds * Docker SBOM generation * Provenance information generation The intention is to keep a similar set of tags generated as before. Signed-off-by: Juan Antonio Osorio <[email protected]>
JAORMX
force-pushed
the
image-build-revamp
branch
from
28f63b4 to
ac69dbc
Compare
Signed-off-by: Juan Antonio Osorio <[email protected]>
JAORMX
force-pushed
the
image-build-revamp
branch
from
4a958e0 to
ba72609
Compare
Signed-off-by: Juan Antonio Osorio <[email protected]>
JAORMX
force-pushed
the
image-build-revamp
branch
from
f3791d4 to
ac931e4
Compare
lukehinds
approved these changes
Feb 19, 2024
There was a problem hiding this comment.
A NB LGTM @JAORMX , but needs an approved commiter
@calebbrown are you able to review?
calebbrown
reviewed
Feb 20, 2024
Comment on lines
+68
to
+69
| tags: ${{ steps.docker-metadata.outputs.tags }} | ||
| labels: ${{ steps.docker-metadata.outputs.labels }} |
There was a problem hiding this comment.
How does the output of this differ when compared the previous implementation for the value of $VERSION?
There was a problem hiding this comment.
should be quite similar as it uses the tag as well, and it strips the v prefix just using github action options. This adds even more metadata to the image.
calebbrown
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the following:
The intention is to keep a similar set of tags generated as before.
this also separates the pre-existing docker workflow into two jobs:
This ensures that we get test coverage for image builds while keeping the GitHub actions permissions minimal.