Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define Automated Test Suite #133

Merged
merged 4 commits into from
Jan 10, 2025
Merged

Define Automated Test Suite #133

merged 4 commits into from
Jan 10, 2025

Conversation

david-a-wheeler
Copy link
Contributor

No description provided.

@david-a-wheeler
Define Automated Test Suite
ba26705 
Signed-off-by: David A. Wheeler <[email protected]>
@funnelfiasco
Copy link
Contributor

I know from our conversation this morning that we called "run make test after your changes" as meeting this criterion, but it's probably worth calling out explicitly that manually-invoked doesn't mean "not automated". I'd offer a wording suggestion, but none has come to me yet.

david-a-wheeler
david-a-wheeler commented Jan 10, 2025
View reviewed changes
baseline.yaml Outdated Show resolved Hide resolved
@david-a-wheeler
Update baseline.yaml
c53f55b 
Signed-off-by: David A. Wheeler <[email protected]>
@david-a-wheeler
Update baseline.yaml
689ca2a 
Signed-off-by: David A. Wheeler <[email protected]>
@david-a-wheeler
Copy link
Contributor Author

funnelfiasco - I added some examples to the definition. I think that eliminates the confusion you noted. Yes? No?

funnelfiasco
funnelfiasco approved these changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@funnelfiasco funnelfiasco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I made a minor refinement suggestion, but I can live with this as-is.

baseline.yaml Outdated Show resolved Hide resolved
@SecurityCRob @funnelfiasco
Update baseline.yaml
db60171 
Co-authored-by: Ben Cotton <[email protected]>
Signed-off-by: CRob <[email protected]>
@SecurityCRob SecurityCRob merged commit 41ca66f into ossf:main Jan 10, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@funnelfiasco funnelfiasco funnelfiasco approved these changes

@puerco puerco puerco approved these changes

@SecurityCRob SecurityCRob SecurityCRob approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@david-a-wheeler @funnelfiasco @puerco @SecurityCRob