New document for gcc and clang annotation recommendations #268
+45
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docs/Compiler-Hardening-Guides/Compiler-Annotations-for-C-and-C++.md
Outdated
Show resolved
Hide resolved
docs/Compiler-Hardening-Guides/Compiler-Annotations-for-C-and-C++.md
Outdated
Show resolved
Hide resolved
gkunz
reviewed
Nov 3, 2023
docs/Compiler-Hardening-Guides/Compiler-Annotations-for-C-and-C++.md
Outdated
Show resolved
Hide resolved
|
@siddhesh : Will you make adjustments per the reviews above? Does the group believe that if these adjustments were made, this should be accepted? |
|
Also: I'd be more directive about standards-based approaches. "In general, prefer approaches that are defined by standards and supported by multiple compilers, e.g., in C++ prefer |
Yes, I just haven't found a block of time to knock them off 😞 . I'll try to do it tonight or tomorrow so that we can discuss it during the call tomorrow if needed. |
Add a document with recommendation for clang and GCC attributes. This is a first draft and needs more information to be added to better describe the implications of each attribute. The document is currently also missing the standard C attribute names for many of these attributes, which could potentially make them even more portable. Signed-off-by: Siddhesh Poyarekar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a document with recommendation for clang and GCC attributes. This is a first draft and needs more information to be added to better describe the implications of each attribute.
The document is currently also missing the standard C attribute names for many of these attributes, which could potentially make them even more portable.