Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci] Create separate CI workflows #116

Merged
merged 9 commits into from
Jul 28, 2022
Merged

[ci] Create separate CI workflows #116

merged 9 commits into from
Jul 28, 2022

Conversation

NikitaZotov
Copy link
Member

@NikitaZotov NikitaZotov commented Jul 25, 2022 •
edited
Loading

New workflow logic:

  • main - building & testing with different compilers or build types
  • style - checking the PR message and code format
  • coverage - collecting the coverage report and sending if to CodeCov
  • sanitizers - running sanitizers

It is rebased from #45

@NikitaZotov NikitaZotov self-assigned this Jul 25, 2022
@NikitaZotov NikitaZotov force-pushed the ci branch 2 times, most recently from 8c3a68f to bbf2f67 Compare July 25, 2022 19:25
@NikitaZotov NikitaZotov added enhancement New feature or request 0.7.0 Rebirth build Fix or feat build step new labels Jul 25, 2022
@NikitaZotov NikitaZotov added this to the 0.7.0 milestone Jul 25, 2022
@NikitaZotov NikitaZotov changed the title [new] Create separate CI workflows [new][ci] Create separate CI workflows Jul 25, 2022
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@516b2a2). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #116   +/-   ##
=======================================
  Coverage        ?   61.98%           
=======================================
  Files           ?      234           
  Lines           ?    15748           
  Branches        ?        0           
=======================================
  Hits            ?     9762           
  Misses          ?     5986           
  Partials        ?        0
Flag Coverage Δ
unittests 61.98% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 516b2a2...528bef8. Read the comment docs.

@NikitaZotov NikitaZotov force-pushed the ci branch 2 times, most recently from ab41d8f to e5f9a02 Compare July 26, 2022 12:12
@NikitaZotov NikitaZotov requested a review from KovalM July 26, 2022 13:05
@NikitaZotov NikitaZotov changed the title [new][ci] Create separate CI workflows [ci] Create separate CI workflows Jul 27, 2022
VasKho
VasKho reviewed Jul 27, 2022
View reviewed changes
FallenChromium
FallenChromium requested changes Jul 27, 2022
View reviewed changes
Copy link
Collaborator

@FallenChromium FallenChromium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caching looks a bit shady, but apart from that it should work fine. Let's fix the issues mentioned above and move to the next round of the review

@NikitaZotov NikitaZotov force-pushed the ci branch 4 times, most recently from 8ce5065 to 8fac362 Compare July 27, 2022 11:38
@NikitaZotov
Copy link
Member Author

#117

FallenChromium
FallenChromium reviewed Jul 27, 2022
View reviewed changes
Copy link
Collaborator

@FallenChromium FallenChromium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍🏻

@NikitaZotov NikitaZotov merged commit 378fa17 into ostis-ai:main Jul 28, 2022
NikitaZotov pushed a commit to NikitaZotov/sc-machine that referenced this pull request Apr 4, 2023
@liwenzu
Section knowledge control added (ostis-ai#116)
d75dd5b 
* section_knowledge_control_2.0
* Modifying format
* Modifying references
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KovalM KovalM KovalM approved these changes

@FallenChromium FallenChromium FallenChromium approved these changes

@VasKho VasKho VasKho approved these changes

Assignees

@NikitaZotov NikitaZotov

Labels
0.7.0 Rebirth build Fix or feat build step enhancement New feature or request
Projects
None yet
Milestone
0.7.0
Development

Successfully merging this pull request may close these issues.
6 participants
@NikitaZotov @codecov-commenter @KovalM @FallenChromium @VasKho @fintarin