Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ellipsis] feat: add env vars for sc-server host and port configuration #457

Closed
wants to merge 5 commits into from

Conversation

ellipsis-dev[bot]
Copy link

@ellipsis-dev ellipsis-dev bot commented Jan 14, 2025

This change addresses review comments left by @NikitaZotov on PR #453: **[tools][server] Environment variables for sc-server host and port **

⚠️ We couldn't build/test your project to verify our changes. Add a Dockerfile to significantly improve code quality.

Summary:

Add environment variables SC_SERVER_HOST and SC_SERVER_PORT for sc-server configuration and update related documentation and logging.

Key points:

  • Environment Variables:
    • Added SC_SERVER_HOST and SC_SERVER_PORT to configure sc-server host and port in docker-compose.yml, sc_machine.md, and sc_machine_runner.cpp.
    • Default values are 127.0.0.1 for host and 8090 for port if not set.
  • Documentation:
    • Updated changelog.md to mention new environment variables.
    • Updated sc_machine.md to include environment variable details.
  • Code Changes:
    • In sc_server_module.cpp, added logic to read SC_SERVER_HOST and SC_SERVER_PORT from environment variables.
    • Modified sc_server.cpp to change log message from "Host name" to "Host".

You can configure Ellipsis to address comments with a direct commit or a side PR, see docs.


Something look wrong? If this Pull Request doesn't address the comments left on the above pull request, create a new PR review with more details. For more information, check the documentation.

Generated with ❤️ by ellipsis.dev

@ellipsis-dev ellipsis-dev bot requested a review from NikitaZotov January 14, 2025 14:25
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 95.69%. Comparing base (1424e78) to head (8a8f250).
Report is 30 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #457      +/-   ##
==========================================
- Coverage   95.70%   95.69%   -0.02%     
==========================================
  Files         237      237              
  Lines       26965    26971       +6     
  Branches     1863     1865       +2     
==========================================
+ Hits        25808    25811       +3     
- Misses       1157     1160       +3     

@NikitaZotov NikitaZotov deleted the ellipsis/jrun_b7ZDh58FgihNWzsI_ocCQ branch January 15, 2025 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant