Migrate to 0.10.0 #368

NikitaZotov · 2025-02-14T11:40:19Z

No description provided.

…rmat scripts

ellipsis-dev · 2025-02-14T11:46:25Z

I couldn't find the pull request #368 in the 'nika' repository. Please verify the pull request details or check if it has been deleted or moved.

NikitaZotov · 2025-02-14T12:00:38Z

@ellipsis, give me a code review

ellipsis-dev · 2025-02-14T12:01:14Z

I'm currently unable to access the pull request for a review due to a technical issue. Please check if the pull request is open and accessible. If the issue persists, consider closing and reopening the pull request or reaching out for further assistance.

kilativ-dotcom · 2025-02-17T07:49:15Z

Dockerfile

+RUN conan remote add ostis-ai https://conan.ostis.net/artifactory/api/conan/ostis-ai-library && \
+    conan profile detect && \
+    conan install . --build=missing

-COPY . /nika
-WORKDIR /nika/scripts
-RUN --mount=type=cache,target=/ccache/ ./build_problem_solver.sh -r
+# Install sc-machine binaries
+RUN curl -LO https://github.com/ostis-ai/sc-machine/releases/download/0.10.0/sc-machine-0.10.0-Linux.tar.gz && \
+    mkdir -p install/sc-machine && tar -xvzf sc-machine-0.10.0-Linux.tar.gz -C install/sc-machine --strip-components 1 && \
+    rm -rf sc-machine-0.10.0-Linux.tar.gz && rm -rf install/sc-machine/include

-FROM base as final
-COPY --from=builder /nika/problem-solver/sc-machine/scripts /nika/problem-solver/sc-machine/scripts
-COPY --from=builder /nika/problem-solver/sc-machine/requirements.txt /nika/problem-solver/sc-machine/requirements.txt
+# Install scl-machine libraries
+RUN curl -LO https://github.com/NikitaZotov/scl-machine/releases/download/0.3.0/scl-machine-0.3.0-Linux.tar.gz && \
+    mkdir -p install/scl-machine && tar -xvzf scl-machine-0.3.0-Linux.tar.gz -C install/scl-machine --strip-components 1 && \
+    rm -rf scl-machine-0.3.0-Linux.tar.gz && rm -rf install/scl-machine/include


I don't understand why are they both used?
conan-ostis-ai is added to download sc- and scl-
and at the same time sc- and scl- are downloaded from github

Previously, you could call agents in scl-machine by initiating an action. If we will allow to use the scl-machine as a Conan package only, we leave only the ability to explicitly call only DirectInferenceAgent from scl-machine in NIKA

when I reviewed scl-machine pr after step 9 it was possible to create Replacements in another project
probably I am not understanding again

I didn't upload an updated version of the scl-machine package to the ostis-ai-library repository. If you want to check if you can use Replacements from scl-machine in another project, you can do it locally. They will be added when I make an official release

what I meant is that I have built scl-machine and exported it and following this guide it was possible to use Replacements in a project
but your message suggested that conan package allows only agent calls
so I am confused because something is not adding up

cmake/ClangFormat.cmake

cmake/install.cmake

docker-compose.yml

docs/build/build_system.md

problem-solver/cxx/message-processing-module/CMakeLists.txt

problem-solver/cxx/message-reply-module/agent/MessageReplyAgent.cpp

problem-solver/cxx/non-atomic-action-interpreter-module/CMakeLists.txt

scripts/run_interface.sh

kilativ-dotcom · 2025-02-20T12:35:21Z

Dockerfile

+RUN conan remote add ostis-ai https://conan.ostis.net/artifactory/api/conan/ostis-ai-library && \
+    conan profile detect && \
+    conan install . --build=missing

-COPY . /nika
-WORKDIR /nika/scripts
-RUN --mount=type=cache,target=/ccache/ ./build_problem_solver.sh -r
+# Install sc-machine binaries
+RUN curl -LO https://github.com/ostis-ai/sc-machine/releases/download/0.10.0/sc-machine-0.10.0-Linux.tar.gz && \
+    mkdir -p install/sc-machine && tar -xvzf sc-machine-0.10.0-Linux.tar.gz -C install/sc-machine --strip-components 1 && \
+    rm -rf sc-machine-0.10.0-Linux.tar.gz && rm -rf install/sc-machine/include

-FROM base as final
-COPY --from=builder /nika/problem-solver/sc-machine/scripts /nika/problem-solver/sc-machine/scripts
-COPY --from=builder /nika/problem-solver/sc-machine/requirements.txt /nika/problem-solver/sc-machine/requirements.txt
+# Install scl-machine libraries
+RUN curl -LO https://github.com/NikitaZotov/scl-machine/releases/download/0.3.0/scl-machine-0.3.0-Linux.tar.gz && \
+    mkdir -p install/scl-machine && tar -xvzf scl-machine-0.3.0-Linux.tar.gz -C install/scl-machine --strip-components 1 && \
+    rm -rf scl-machine-0.3.0-Linux.tar.gz && rm -rf install/scl-machine/include


when I reviewed scl-machine pr after step 9 it was possible to create Replacements in another project
probably I am not understanding again

docs/build/quick_start.md

docs/index.ru.md

kilativ-dotcom · 2025-02-20T14:23:39Z

docs/quick_start.md

+6. Run sc-web:
+
+    ```sh
+    source .venv/bin/activate && python3 server/app.py
+    ```


just all other steps are executed from project root

kilativ-dotcom · 2025-02-20T14:31:56Z

problem-solver/cxx/common-module/include/common/searcher/MessageSearcher.hpp


-namespace dialogControlModule
+namespace commonModule


so now module with agents cannot be a dependency because agents will be registered 2 times?
but this does not happen with scl-machine, it is a dependency for dialog-control and message-classification
or you just assumed that this searcher belongs to common module and not dialog-control?

...r/cxx/dialog-control-module/test/tests-structures/standard-message-reply/logic-rules/lr1.scs

…invocations

kilativ-dotcom

I replied in threads

NikitaZotov added 30 commits February 7, 2025 12:06

feat(git): remove sc-machine and scl-machine submodules

677913a

feat(scripts): remove install, build and run scripts; update clang fo…

775f1e8

…rmat scripts

feat(solver): move to new build system

83a151d

feat(cmake): update root cmakes

2fb7115

feat: add conanfile

cdba859

feat(git): ignore ConanPresets.json

7ca0958

refactor: problem solver

7b18797

feat(build): include scl-machine inference library

8b6c0c1

feat(solver): include inference template manager

c2d29ef

fix(solver): MessageTopicClassifier seg fault

b91e7c4

feat(interface): move to ts-sc-client 0.5.0

5fa67e5

feat(solver): move C++ solver to API 0.10.0

69935f3

feat(solver): move Python solver to API 0.10.0

01d9007

feat(kb): remove deprecated sc-type elements

f1e80f5

feat: update config file

a4c867e

feat: update repo.path

d64356e

feat(docker): update docker files

50f4737

feat(cmake): bump scl-machine version

af746d8

git: ignore install folder

ee399a5

feat(solver): remove deprecated types

5e37e39

git: don't ignore unused files

0cdadc7

feat(docs): update index docs

b975d77

feat(docs): add quick start for users

5d77bae

feat(docs): rename docker build files

78da3cb

feat(docs): remove linux build files

30d4be8

feat(docs): move CONTRIBUTING to docs folder

ee38bbb

fix(docs): fix incorrects in index of docs

dbd0af3

feat(scripts): add install dev dependencies script

155c065

feat(docs): add quick start for users

f178e70

feat(docs): add quick start for contributors

27d850f

refactor: replace deprecated types with new ones in scs sources

05ec5aa

NikitaZotov force-pushed the feat/migrate_to_0.10.0 branch from 1cb3a70 to 05ec5aa Compare February 14, 2025 11:55

NikitaZotov added 2 commits February 14, 2025 14:57

refactor(ci): names of steps

eccb2e8

feat(cmake): check OS before setting vars

ec78183

NikitaZotov requested a review from MikhailSadovsky February 14, 2025 12:01

NikitaZotov requested a review from kilativ-dotcom February 14, 2025 12:01

feat: change Conan remote url

cad365f

NikitaZotov force-pushed the feat/migrate_to_0.10.0 branch from 531b8f6 to cad365f Compare February 16, 2025 09:30

NikitaZotov added 5 commits February 17, 2025 16:36

fix(docker): linking extensions with libraries

890f3df

fix(wit): read config path

3fbb755

fix(chat-footer): extra typing

c9c69e0

fix(classifier): not duplicate generating entities

b5f5c4b

fix(docs): url to docs

7b49b47

kilativ-dotcom requested changes Feb 17, 2025

View reviewed changes

NikitaZotov added 7 commits February 18, 2025 15:11

fix(docs): incorrects after review

3a94093

fix(cmake): description of component

3a69cd1

fix(cmake): don't ignore generated folder by clang-format

f5b0c34

fix(solver): names of objects

588e33e

fix(docs): clarify info about agent of message classification

5c91391

fix(docs): incorrects after review

34ca32d

fix(solver): don't use using namespace in hpp files

a3133d9

NikitaZotov requested a review from kilativ-dotcom February 18, 2025 12:41

kilativ-dotcom requested changes Feb 20, 2025

View reviewed changes

NikitaZotov added 2 commits February 21, 2025 18:05

feat(solver): fix type of relations in test sc.s-sources

a782cc1

feat(docs): update nika.ini and scl-machine extensions in sc-machine …

2dce7e0

…invocations

NikitaZotov requested a review from kilativ-dotcom February 21, 2025 15:10

kilativ-dotcom reviewed Feb 24, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migrate to 0.10.0 #368

Migrate to 0.10.0 #368

NikitaZotov commented Feb 14, 2025

ellipsis-dev bot commented Feb 14, 2025

NikitaZotov commented Feb 14, 2025

ellipsis-dev bot commented Feb 14, 2025

kilativ-dotcom Feb 17, 2025

NikitaZotov Feb 18, 2025

kilativ-dotcom Feb 20, 2025

NikitaZotov Feb 21, 2025

kilativ-dotcom Feb 24, 2025

kilativ-dotcom Feb 20, 2025

kilativ-dotcom Feb 20, 2025

kilativ-dotcom Feb 20, 2025

kilativ-dotcom left a comment

Migrate to 0.10.0 #368

Are you sure you want to change the base?

Migrate to 0.10.0 #368

Conversation

NikitaZotov commented Feb 14, 2025

ellipsis-dev bot commented Feb 14, 2025

NikitaZotov commented Feb 14, 2025

ellipsis-dev bot commented Feb 14, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kilativ-dotcom left a comment

Choose a reason for hiding this comment