Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show You can drag it tooltip fix #60 #63

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

mocno
Copy link

@mocno mocno commented Jul 26, 2023

issue #60: Show a You can click and drag this icon around tooltip next to settings icon when settings are opened

@mocno mocno changed the title Show you can drag it tooltip fix #60 Show You can drag it tooltip fix #60 Jul 26, 2023
Copy link
Contributor

@LittleEndu LittleEndu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Multiple things wrong with this:

  • the image in the issue thread was never meant to appear. Sending memes in a discord is probably fair use, but releasing that image in an userscript 100% isn't.
  • any image/tooltip that gets used needs to be visible in any orientation of the settings icon. Right now you can hide the image by just dragging the icon to the left.
  • the diff includes multiple changes not mentioned in the PR nor commit description, some of these changes are definitely unwanted like renaming multiple unrelated variables or removing curly braces around while/if statements and other code quality related changes.
  • there should be no "// change after pull request" situations. Either your pull request works or it doesn't

@mocno
Copy link
Author

mocno commented Jul 27, 2023

Multiple things wrong with this:

  • the image in the issue thread was never meant to appear. Sending memes in a discord is probably fair use, but releasing that image in an userscript 100% isn't.
  • any image/tooltip that gets used needs to be visible in any orientation of the settings icon. Right now you can hide the image by just dragging the icon to the left.
  • the diff includes multiple changes not mentioned in the PR nor commit description, some of these changes are definitely unwanted like renaming multiple unrelated variables or removing curly braces around while/if statements and other code quality related changes.
  • there should be no "// change after pull request" situations. Either your pull request works or it doesn't

ok, i will work on it.

@mocno mocno requested a review from LittleEndu July 27, 2023 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants