-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show You can drag it
tooltip fix #60
#63
Open
mocno
wants to merge
7
commits into
osuplace:main
Choose a base branch
from
mocno:show-you-can-drag-it-tooltip_fix-#60
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mocno
changed the title
Show you can drag it tooltip fix #60
Show Jul 26, 2023
You can drag it
tooltip fix #60
LittleEndu
requested changes
Jul 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Multiple things wrong with this:
- the image in the issue thread was never meant to appear. Sending memes in a discord is probably fair use, but releasing that image in an userscript 100% isn't.
- any image/tooltip that gets used needs to be visible in any orientation of the settings icon. Right now you can hide the image by just dragging the icon to the left.
- the diff includes multiple changes not mentioned in the PR nor commit description, some of these changes are definitely unwanted like renaming multiple unrelated variables or removing curly braces around while/if statements and other code quality related changes.
- there should be no "
// change after pull request
" situations. Either your pull request works or it doesn't
ok, i will work on it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue #60: Show a
You can click and drag this
icon around tooltip next to settings icon when settings are opened