fix: don't crash if schema cache directories already exist #365
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋 Hi there. Thank you for creating the library. It's super useful!
One problem I noticed happening in our GitHub CI process is that it crashed sometimes and the error was:
Which was caused by
fs.mkdirSync
throwing an error when a directory already exists.I swapped this with
fs.mkdirSync('<path to dir>', { recursive: true })
which will not throw if the directory exists AND has the added benefit that it automatically creates any missing parent directory which means you don't need themakeDirs
helper function.