add servers #146
Open
add servers #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ota42y
requested changes
Feb 23, 2023
| # @return [OpenAPIParser::RequestOperation, nil] | ||
| def request_operation(http_method, request_path) | ||
| OpenAPIParser::RequestOperation.create(http_method, request_path, @path_item_finder, @config) | ||
| OpenAPIParser::RequestOperation.create(http_method, request_path, @path_item_finder, @config, servers) |
There was a problem hiding this comment.
I think we don't need to pass Server Object.
The RequestOperation object for validating using Operation Object.
The Operation Object specified by path and http method so it don't care about server URL so they don't need to Server Object which define server URL.
(This object is intended to run on a server that accepts requests. This object is supposed to run on the server that accepts requests, although it can also be used on the client side.)
I think we should add validate method to Server Object and call it from OpenAPI Object.
(The client validate URL using that method before send request )
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ota42y token of appreciation for taking your time helping me. 🙏