Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue in creature.cpp adding skull to master on summon AoE attacks #4889

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jromap7
Copy link

@jromap7 jromap7 commented Jan 28, 2025

Changes Proposed

Added code to ensure that when a player's summon damages another player with an AoE attack, the master player is correctly assigned a skull.

Code added:

if (attacker->getMaster() && attacker->getMaster()->getPlayer()) {
	Player* masterPlayer = attacker->getMaster()->getPlayer();
	masterPlayer->onAttackedCreature(this);
}

Issues Addressed

Fixes the bug where a player's summon (e.g., fire devil or fire elemental) using AoE spells did not assign a skull to the master player when damaging other players.

How to Test

  1. Summon a creature (e.g., fire devil or fire elemental) as a player.
  2. Have the summon cast an AoE spell near another player. You can summon 2 Fire Devils and make one attack the other.
  3. Verify that the master player receives a skull when the AoE damages the other player.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant