Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added templates (draft) #13

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

BatiGencho
Copy link

No description provided.

Copy link
Contributor

@gnmerritt gnmerritt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems good to me so far. what happens if you pass both a template and a body to the send API - terrible things?

happy to merge this when you're happy with it and sorry for the long delay in getting back to you

pub description: String,
pub template: Option<String>,
pub tag: Option<String>,
pub engine: Option<String>,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we make this a single-value enum so that it's only possible to pass in handlebars for now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants