Improve CPU consumption by skipping populateReferencedKubernetesServices logic when egress enforcement is disabled
#538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es` only if egress is enabled
amitlicht
approved these changes
Dec 22, 2024
omris94
changed the title
populateReferencedKubernetesServices only if egress is enabledpopulateReferencedKubernetesServices logic when egress enforcement is disabled
omris94
deleted the
omris/populate-referanced-services-only-if-egress
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When building serviceEffectivePolicies -
populateReferencedKubernetesServiceslogic is the heaviest part regarding CPU consumption. This logic is relevant only for egress policies (to work around AWS CNI limitation). Therefore, in this PR we changed it so it will only run if egress is enabled.