Fix bug where AWS IAM roles could be created for a particular workload even when disabled for that particular workload #549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ds labeled with 'credentials-operator.otterize.com/create-aws-role=false'
2 tasks
amitlicht
changed the title
omris94
approved these changes
Jan 21, 2025
orishoshan
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue with the AWS IAM integration, where pods labeled with
credentials-operator.otterize.com/create-aws-rolewere assigned an Otterize-generated IAM role, ignoring the label value. Meaning that if a pod was labeled withcredentials-operator.otterize.com/create-aws-role=false, the integration would still create and assign an IAM role for it, possibly overriding any other user-managed role assigned to it.References
otterize/credentials-operator#178
#549
Testing
Describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If this library has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.
Please include any manual steps for testing end-to-end or functionality not covered by unit/integration tests.
Also include details of the environment this PR was developed in (language/platform/browser version).
Checklist